Skip to content

task: add join_all method to JoinSet #6784

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Aug 26, 2024
+114 −1
Merged

task: add join_all method to JoinSet #6784

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
ab0b697
task: add join_all method to JoinSet
hmaka Aug 16, 2024
b0ee2fc
Update tokio/tests/task_join_set.rs
hmaka Aug 17, 2024
f8cabd6
task: improve join_all docs and provide examples
hmaka Aug 21, 2024
ab49b42
task: fix/update docs examples
hmaka Aug 21, 2024
7542e4e
Update join_set.rs
hmaka Aug 23, 2024
9d37eee
Update join_set.rs
hmaka Aug 23, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Update join_set.rs 
Co-authored-by: Motoyuki Kimura <[email protected]>
  • Loading branch information
@hmaka @mox692
hmaka and mox692 authored Aug 23, 2024
commit 9d37eee8ab3b51eef992360573580ee121051a46
2 changes: 1 addition & 1 deletion tokio/src/task/join_set.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -375,8 +375,8 @@ impl<T: 'static> JoinSet<T> {
}

/// Awaits the completion of all tasks in this `JoinSet`, returning a vector of their results.
/// The results will be stored in the order they completed not the order they were spawned.
///
/// The results will be stored in the order they completed not the order they were spawned.
/// This is a convenience method that is equivalent to calling [`join_next`] in
/// a loop. If any tasks on the `JoinSet` fail with an [`JoinError`], then this call
/// to `join_all` will panic and all remaining tasks on the `JoinSet` are
Expand Down