chore: Bump windows-sys to version 0.61 #7645
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
whollins
force-pushed
the
bump-windows-sys
branch
3 times, most recently
from
c0eda79 to
ed407b2
Compare
whollins
changed the title
whollins
force-pushed
the
bump-windows-sys
branch
from
ed407b2 to
5444a69
Compare
Member
Member
|
We need to update windows-sys in mio and socket2, which are our dependencies. There's already an open PR for mio (tokio-rs/mio#1901), but not for socket2. Could you open one for it? |
Contributor
|
Problem is the new MSRV of 1.71 in windows-sys. |
ADD-SP
added
S-blocked-on-msrv
Contributor
|
This could probably solved as proposed in tokio-rs/mio#1901, by allowing both 0.60 and 0.61 versions. |
Contributor
|
Are the range versions a good solution to this? I'm not sure if Mio or Socket2 will hit a breaking change in them. |
Contributor
|
I bumped the MSRV to 1.71 in #7658, so we can land this. Please rebase. |
4 tasks
whollins
force-pushed
the
bump-windows-sys
branch
from
5444a69 to
fc1f1d5
Compare
Contributor
Author
Done |
Darksonn
approved these changes
Oct 7, 2025
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Update the windows-sys dependency to the latest version.
Solution
Minor change needed as the BOOLEAN type has been removed but a standard bool is
the replacement.