fix: I18nContext.current() undefined when using additional interceptors #594
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I discovered a bug when using
disableMiddleware: true.When relying on
I18nLanguageInterceptorto initialize theI18nContext, it's not possible to use another interceptor on the same endpoint.When doing so, the
AsyncLocalStoragecontaining the i18n context is broken:I18nContext.current()always returnsundefined.How to reproduce
disableMiddleware: trueinI18nModuleoptions.undefinedinstead of the resolved lang. When removing the interceptor it works.Additional context
I did something similar to the
nestjs-cls's interceptor implementation: https://github.com/Papooch/nestjs-cls/blob/main/packages/core/src/lib/cls-initializers/cls.interceptor.tsI just simplified it by passing the observer directly to the
subscribemethod.I added a test in
i18n-disable-middleware.e2e.spec.tsto avoid regressions.See also: