fix: remove i18nOptions from I18nContext class #675
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The root cause stems from this pull request:
#653
We cannot access the
i18nOptionspassed from the constructor within the static functionI18nContext.current. And when an error occurs in any middleware, the I18nContext will not be initialized, causing this.storage.getStore() to return undefined.Steps to reproduce this issue:
I use i18n in a
GlobalExceptionFilterclass:Trigger an error in a different middleware:
The error occurs here: I18nContext.current(host);
Linked Issues
Additional context