Skip to content

Conversation

@cskiwi
Copy link
Contributor

@cskiwi cskiwi commented Jul 14, 2025

Description

update to nestjs 11

Also moved:

  • apollo-client from apollo-client to @apollo/client
  • InMemoryCache and NormalizedCacheObject from apollo-cache-inmemory to @apollo/client

Linked Issues

Additional context

@rubiin rubiin requested a review from Copilot July 15, 2025 00:29
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR upgrades the project to NestJS 11 and aligns related Apollo client imports, adds manual validation in the Cat resolver, and strengthens cleanup/error formatting in i18n tests.

  • Bump NestJS and @apollo/client dependencies
  • Wrap test file cleanup in try/catch and enhance GraphQL error formatting
  • Replace global validation pipe with manual validation in CatResolver

Reviewed Changes

Copilot reviewed 7 out of 9 changed files in this pull request and generated no comments.

Show a summary per file
File Description
tests/i18n.yaml.spec.ts Added try/catch around file and directory cleanup
tests/i18n.spec.ts Added try/catch around file and directory cleanup
tests/i18n-gql.e2e.spec.ts Migrated to @apollo/client, added error formatter in tests
tests/app/cats/cat.resolver.ts Switched to manual class-validator flow in resolver
src/services/i18n.service.ts Adjusted parentheses in nested translation ternary
src/types.ts Reformatted ternary type alias into a single line
package.json Upgraded NestJS, Apollo, and related dependencies
Comments suppressed due to low confidence (4)

tests/app/cats/cat.resolver.ts:16

  • You reference I18nValidationException in this file but there’s no import for it—add the appropriate import from your exception definitions.
import { formatI18nErrors } from '../../../src/utils';

tests/app/cats/cat.resolver.ts:72

  • PubSub from graphql-subscriptions provides asyncIterator, not asyncIterableIterator. Change this back to this.pubSub.asyncIterator('catAdded').
    return this.pubSub.asyncIterableIterator('catAdded');

tests/i18n.yaml.spec.ts:125

  • Using fs.rmdirSync may fail on non-empty directories. Consider using fs.rmSync(newLanguagePath, { recursive: true, force: true }) for more reliable cleanup.
        fs.unlinkSync(newTranslationPath);

src/services/i18n.service.ts:278

  • [nitpick] The extra parentheses around the true branch of this ternary are redundant; removing them would simplify the expression.
            ? ((this.translateObject(

@coveralls
Copy link

Coverage Status

coverage: 90.564% (-0.4%) from 90.917%
when pulling f78d5da on cskiwi:feat/nestjs-11
into 4341986 on toonvanstrijp:main.

@rubiin rubiin merged commit 1896179 into toonvanstrijp:main Jul 15, 2025
3 checks passed
@rubiin rubiin changed the title nestjs 11 feat: nestjs 11 Jul 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants