-
Notifications
You must be signed in to change notification settings - Fork 956
Update README.md #1016
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update README.md #1016
Conversation
Please make sure all the checkboxes are checked:
|
WalkthroughThe README.md for the cognee-mcp project was extensively rewritten, transforming it from a brief guide into a structured manual. The update introduces segmented sections covering overview, installation, configuration, running the server, development workflow, troubleshooting, and maintenance, providing detailed and formalized documentation for users and developers. Changes
Sequence Diagram(s)sequenceDiagram
participant User
participant Documentation (README.md)
User->>Documentation (README.md): Read Overview and Installation
User->>Documentation (README.md): Follow Configuration steps
User->>Documentation (README.md): Run server using provided instructions
User->>Documentation (README.md): Refer to Troubleshooting/Maintenance as needed
Possibly related PRs
Suggested reviewers
Poem
✨ Finishing Touches🧪 Generate Unit Tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
🧹 Nitpick comments (4)
cognee-mcp/README.md (4)
12-17: Add missing prerequisites (Node.js & Poetry).The Smithery installer relies on
npx, and the development workflow later usespoetry, yet neither tool is listed in the prerequisites. Readers following the guide on a fresh machine may hit confusing “command not found” errors.- Homebrew (macOS/Linux) - Python 3.9+ +- Node.js 18 + (required for the Smithery CLI) +- Poetry (required for building local Cognee wheels) - Claude Desktop installed
40-43: Mention Node.js install step or link to docs for Smithery path.After adding Node.js to the prerequisites, consider a one-liner here (or a link) showing how to install it (
brew install node,asdf, etc.). This keeps the “automated” path truly one-command for new contributors.
59-75: Store secrets in environment variables, not plaintext JSON.The sample shows an actual key-value pair for
LLM_API_KEY. Even as a placeholder, newcomers often copy–paste and commit real keys by accident. Swap to an interpolated env-var to reinforce best practice:- "LLM_API_KEY": "sk-your-api-key-here" + "LLM_API_KEY": "${LLM_API_KEY}"…and remind users to export the variable in their shell or a
.envfile that’s git-ignored.
121-125: Specify a language for the fenced code block (markdownlint MD040).-``` +```text http://localhost:5173?timeout=120000This silences the linter and renders the block consistently across Markdown viewers. </blockquote></details> </blockquote></details> <details> <summary>📜 Review details</summary> **Configuration used: CodeRabbit UI** **Review profile: CHILL** **Plan: Pro** <details> <summary>📥 Commits</summary> Reviewing files that changed from the base of the PR and between 96d1111d08d0d07f6c40d60470d2d4aec38880f8 and 39e80e5d3ee4705034f925acd11c9b2e5a395138. </details> <details> <summary>📒 Files selected for processing (1)</summary> * `cognee-mcp/README.md` (1 hunks) </details> <details> <summary>🧰 Additional context used</summary> <details> <summary>🪛 markdownlint-cli2 (0.17.2)</summary> <details> <summary>cognee-mcp/README.md</summary> 123-123: Fenced code blocks should have a language specified null (MD040, fenced-code-language) </details> </details> </details> </details> <!-- This is an auto-generated comment by CodeRabbit for review status -->
| 1. Build Cognee package: | ||
| ```bash | ||
| poetry build -o ./cognee-mcp/sources | ||
| ``` | ||
|
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Incorrect Poetry flag – -o is not supported.
poetry build accepts --output / --output-dir; the short -o flag will raise “unknown option” on recent Poetry versions.
-poetry build -o ./cognee-mcp/sources
+poetry build --format wheel --output ./cognee-mcp/sources📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| 1. Build Cognee package: | |
| ```bash | |
| poetry build -o ./cognee-mcp/sources | |
| ``` | |
| 1. Build Cognee package: |
🤖 Prompt for AI Agents
In cognee-mcp/README.md around lines 97 to 101, the poetry build command uses
the unsupported short flag '-o'. Replace '-o' with the correct long flag
'--output' or '--output-dir' to specify the output directory for the build
artifacts, ensuring compatibility with recent Poetry versions.
|
@siddharth0-dev thank you for the contribution. We do not encourage readme PRs, but feel free to open a ticket and we will change based on the request and if it makes sense |
Description
DCO Affirmation
I affirm that all code in every commit of this pull request conforms to the terms of the Topoteretes Developer Certificate of Origin.