-
Notifications
You must be signed in to change notification settings - Fork 1k
add bge-m3 embeddings model to package #1057
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Please make sure all the checkboxes are checked:
|
|
Caution Review failedThe pull request is closed. WalkthroughThis update introduces a new FlagEmbedding engine and tokenizer, extends embedding engine selection, and improves file handling, graph operations, and retrieval instrumentation. It also enhances error handling, logging, and dataset management, while adding utility methods for graph metadata and related chunk export. Several debugging outputs are included. Changes
Sequence Diagram(s)sequenceDiagram
participant User
participant App
participant FlagEmbeddingEngine
participant Tokenizer
participant RemoteEndpoint
User->>App: Request text embedding
App->>FlagEmbeddingEngine: embed_text(texts)
alt Local model available
FlagEmbeddingEngine->>Tokenizer: Tokenize texts
FlagEmbeddingEngine->>FlagEmbeddingEngine: Encode texts locally
FlagEmbeddingEngine-->>App: Return embeddings
else Remote endpoint fallback
FlagEmbeddingEngine->>RemoteEndpoint: POST /embed texts
RemoteEndpoint-->>FlagEmbeddingEngine: Return embeddings
FlagEmbeddingEngine-->>App: Return embeddings
end
App-->>User: Return result
sequenceDiagram
participant App
participant QDrantAdapter
participant QDrantClient
App->>QDrantAdapter: search(collection_name, query, limit)
QDrantAdapter->>QDrantClient: search(...)
alt Collection not found
QDrantClient-->>QDrantAdapter: UnexpectedResponse("Collection not found")
QDrantAdapter-->>App: Raise CollectionNotFoundError
else Limit <= 0
QDrantAdapter-->>App: Return []
else Success
QDrantClient-->>QDrantAdapter: Return results
QDrantAdapter-->>App: Return results
end
Possibly related PRs
Suggested reviewers
Poem
📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (16)
✨ Finishing Touches
🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
|
my dummy |
No description provided.