Skip to content

Conversation

@pazone
Copy link
Contributor

@pazone pazone commented Oct 30, 2025

Description

Reduces the amount of macOS and Windows jobs by running these tests only for the latest python version in the list.
different-os-tests-basic runs tests on ubuntu and python '["3.10.x", "3.11.x", "3.12.x", "3.13.x"]'
different-os-tests-extended runs windows and macOS tests for python 3.13.x.

Type of Change

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation update
  • Code refactoring
  • Performance improvement
  • Other (please specify):

Screenshots/Videos (if applicable)

Pre-submission Checklist

  • I have tested my changes thoroughly before submitting this PR
  • This PR contains minimal changes necessary to address the issue/feature
  • My code follows the project's coding standards and style guidelines
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if applicable)
  • All new and existing tests pass
  • I have searched existing PRs to ensure this change hasn't been submitted already
  • I have linked any relevant issues in the description
  • My commits have clear and descriptive messages

DCO Affirmation

I affirm that all code in every commit of this pull request conforms to the terms of the Topoteretes Developer Certificate of Origin.

@pull-checklist
Copy link

Please make sure all the checkboxes are checked:

  • I have tested these changes locally.
  • I have reviewed the code changes.
  • I have added end-to-end and unit tests (if applicable).
  • I have updated the documentation and README.md file (if necessary).
  • I have removed unnecessary code and debug statements.
  • PR title is clear and follows the convention.
  • I have tagged reviewers or team members for feedback.

@pazone pazone requested review from Copilot and dexters1 October 30, 2025 09:55
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Oct 30, 2025

Important

Review skipped

Review was skipped due to path filters

⛔ Files ignored due to path filters (2)
  • .github/workflows/test_different_operating_systems.yml is excluded by !**/*.yml
  • .github/workflows/test_suites.yml is excluded by !**/*.yml

CodeRabbit blocks several paths by default. You can override this behavior by explicitly including those paths in the path filters. For example, including **/dist/** will override the default block on the dist directory, by removing the pattern from both the lists.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Note

Other AI code review bot(s) detected

CodeRabbit has detected other AI code review bot(s) in this pull request and will avoid duplicating their findings in the review comments. This may lead to a less comprehensive review.

✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR refactors the operating system testing strategy by splitting it into two separate workflows: a basic test that runs all Python versions on Ubuntu, and an extended test that runs only Python 3.13.x on macOS and Windows. This approach optimizes CI runtime by reducing redundant cross-platform testing while maintaining comprehensive coverage.

Key Changes

  • Split different-operating-systems-tests into different-os-tests-basic (Ubuntu with all Python versions) and different-os-tests-extended (macOS/Windows with Python 3.13.x only)
  • Added an os input parameter to the reusable workflow to make operating systems configurable
  • Updated all job dependencies and success condition checks to reference the two new test jobs

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.

File Description
.github/workflows/test_suites.yml Splits the operating system tests into two separate jobs (basic and extended) and updates all references in dependency lists and success conditions
.github/workflows/test_different_operating_systems.yml Adds a new os input parameter and replaces hardcoded OS matrix values with the dynamic input

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@pazone pazone marked this pull request as ready for review October 30, 2025 10:08
@Vasilije1990
Copy link
Contributor

@pazone why are tests failing?

@pazone
Copy link
Contributor Author

pazone commented Oct 31, 2025

@Vasilije1990 It's a forked PR and the secrets are not resolved. I think I need to recreate the PR using a non-forked branch

@pazone pazone marked this pull request as draft October 31, 2025 10:01
@pazone
Copy link
Contributor Author

pazone commented Oct 31, 2025

@Vasilije1990 Ollama test is failing due to incorrect ollama API usage. This PR is supposed to fix that.

@pazone pazone marked this pull request as ready for review October 31, 2025 15:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants