-
Notifications
You must be signed in to change notification settings - Fork 954
CI: Extract Windows and MacOS tests to separate job #1703
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Please make sure all the checkboxes are checked:
|
|
Important Review skippedReview was skipped due to path filters ⛔ Files ignored due to path filters (2)
CodeRabbit blocks several paths by default. You can override this behavior by explicitly including those paths in the path filters. For example, including You can disable this status message by setting the Note Other AI code review bot(s) detectedCodeRabbit has detected other AI code review bot(s) in this pull request and will avoid duplicating their findings in the review comments. This may lead to a less comprehensive review. ✨ Finishing touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR refactors the operating system testing strategy by splitting it into two separate workflows: a basic test that runs all Python versions on Ubuntu, and an extended test that runs only Python 3.13.x on macOS and Windows. This approach optimizes CI runtime by reducing redundant cross-platform testing while maintaining comprehensive coverage.
Key Changes
- Split
different-operating-systems-testsintodifferent-os-tests-basic(Ubuntu with all Python versions) anddifferent-os-tests-extended(macOS/Windows with Python 3.13.x only) - Added an
osinput parameter to the reusable workflow to make operating systems configurable - Updated all job dependencies and success condition checks to reference the two new test jobs
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
.github/workflows/test_suites.yml |
Splits the operating system tests into two separate jobs (basic and extended) and updates all references in dependency lists and success conditions |
.github/workflows/test_different_operating_systems.yml |
Adds a new os input parameter and replaces hardcoded OS matrix values with the dynamic input |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
@pazone why are tests failing? |
|
@Vasilije1990 It's a forked PR and the secrets are not resolved. I think I need to recreate the PR using a non-forked branch |
|
@Vasilije1990 Ollama test is failing due to incorrect ollama API usage. This PR is supposed to fix that. |
Description
Reduces the amount of macOS and Windows jobs by running these tests only for the latest python version in the list.
different-os-tests-basicruns tests on ubuntu and python'["3.10.x", "3.11.x", "3.12.x", "3.13.x"]'different-os-tests-extendedruns windows and macOS tests for python3.13.x.Type of Change
Screenshots/Videos (if applicable)
Pre-submission Checklist
DCO Affirmation
I affirm that all code in every commit of this pull request conforms to the terms of the Topoteretes Developer Certificate of Origin.