fix: Resolve issue with text classification

[dexters1]

Description

Resolve issue with text file classification

Type of Change

• Bug fix (non-breaking change that fixes an issue)
• New feature (non-breaking change that adds functionality)
• Breaking change (fix or feature that would cause existing functionality to change)
• Documentation update
• Code refactoring
• Performance improvement
• Other (please specify):

Screenshots/Videos (if applicable)

Pre-submission Checklist

• I have tested my changes thoroughly before submitting this PR
• This PR contains minimal changes necessary to address the issue/feature
• My code follows the project's coding standards and style guidelines
• I have added tests that prove my fix is effective or that my feature works
• I have added necessary documentation (if applicable)
• All new and existing tests pass
• I have searched existing PRs to ensure this change hasn't been submitted already
• I have linked any relevant issues in the description
• My commits have clear and descriptive messages

DCO Affirmation

I affirm that all code in every commit of this pull request conforms to the terms of the Topoteretes Developer Certificate of Origin.

[pull-checklist]

Please make sure all the checkboxes are checked:

• I have tested these changes locally.
• I have reviewed the code changes.
• I have added end-to-end and unit tests (if applicable).
• I have updated the documentation and README.md file (if necessary).
• I have removed unnecessary code and debug statements.
• PR title is clear and follows the convention.
• I have tagged reviewers or team members for feedback.

[coderabbitai]

Important

Review skipped

Review was skipped due to path filters

⛔ Files ignored due to path filters (2)

• pyproject.toml is excluded by !**/*.toml
• uv.lock is excluded by !**/*.lock, !**/*.lock

CodeRabbit blocks several paths by default. You can override this behavior by explicitly including those paths in the path filters. For example, including **/dist/** will override the default block on the dist directory, by removing the pattern from both the lists.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Walkthrough

File type detection logic is enhanced by introducing an optional name parameter through the utility chain. This enables metadata retrieval and type-guessing functions to leverage file names when available. Explicit text extension handling is added to reduce ambiguity for text files. One WAV audio MIME type is added to the audio loader's supported formats.

Changes

Cohort / File(s)	Summary
File Type Detection Utilities cognee/infrastructure/files/utils/get_file_metadata.py, cognee/infrastructure/files/utils/guess_file_type.py	Extended signatures to accept optional name parameter. guess_file_type now handles text extensions (.txt, .text) explicitly before falling back to filetype.guess. Imports reorganized; fallback behavior to text/plain type retained.
Audio Loader cognee/infrastructure/loaders/core/audio_loader.py	Added "audio/x-wav" MIME type to supported formats list.
Binary Data Ingestion cognee/modules/ingestion/data_types/BinaryData.py	Updated ensure_metadata to pass optional name parameter to get_file_metadata, enabling name-aware metadata retrieval.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

• Review the text extension handling logic in guess_file_type.py to ensure it correctly short-circuits and maintains compatibility with existing fallback behavior
• Verify the optional name parameter is correctly threaded through the call chain without breaking existing callers
• Confirm the WAV MIME type addition doesn't conflict with existing audio handling

Suggested reviewers

• borisarzentar

Poem

🐰 A name through the chain we now pass,

Text files detected with newfound class,

WAV audio welcomed with open ears,

File metadata blooms without fears! 📁✨

Pre-merge checks and finishing touches

❌ Failed checks (2 warnings)

Check name	Status	Explanation	Resolution
Description Check	⚠️ Warning	The pull request description is largely incomplete and does not adequately follow the provided template. While the Description section is present, it consists of only one sentence with minimal explanation of the changes, thought process, or reasoning—which the template explicitly requests. More critically, the Type of Change section has no checkboxes selected, the Pre-submission Checklist is entirely unchecked, and no detailed context is provided about what the changes accomplish or why they were necessary. This does not meet the standard of being "mostly complete" as required for a passing assessment.	The author should provide a more detailed description explaining the issue being resolved, the approach taken, and the rationale behind the changes. Additionally, they must select the appropriate Type of Change checkbox (likely "Bug fix"), check off the applicable Pre-submission Checklist items that they have completed, and provide clear explanations rather than relying on generic descriptions.
Docstring Coverage	⚠️ Warning	Docstring coverage is 60.00% which is insufficient. The required threshold is 80.00%.	You can run @coderabbitai generate docstrings to improve docstring coverage.

✅ Passed checks (1 passed)

Check name	Status	Explanation
Title Check	✅ Passed	The pull request title "fix: Resolve issue with text classification" is directly related to the main changes in the changeset. The raw summary shows that the core modifications enhance text file type detection by adding an optional name parameter throughout the file metadata chain and explicitly handling textual file extensions (.txt, .text). While the title is somewhat generic and could be more specific about the mechanism (e.g., mentioning the filename parameter), it clearly communicates the primary objective of the PR and accurately summarizes the main change from the developer's perspective.

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[coderabbitai]

Actionable comments posted: 1

Caution

Some comments are outside the diff and can’t be posted inline due to platform limitations.

⚠️ Outside diff range comments (3)

cognee/infrastructure/files/utils/guess_file_type.py (2)

28-44: Update docstring to document the name parameter.

The function signature now accepts an optional name parameter, but the docstring doesn't document it.

Apply this diff to update the docstring:

     Parameters:
     -----------
 
         - file (BinaryIO): A binary file stream to analyze for determining the file type.
+        - name (Optional[str]): Optional filename to use for extension-based type inference.
 
     Returns:

---

58-66: Remove unreachable code.

Lines 64-65 are unreachable because line 62 ensures file_type is never None at that point. The exception can never be raised.

Apply this diff to remove the dead code:

     file_type = filetype.guess(file)
 
     # If file type could not be determined consider it a plain text file as they don't have magic number encoding
     if file_type is None:
         file_type = Type("text/plain", "txt")
 
-    if file_type is None:
-        raise FileTypeException(f"Unknown file detected: {file.name}.")
-
     return file_type

cognee/infrastructure/files/utils/get_file_metadata.py (1)

30-56: Update docstring to document the name parameter.

The implementation correctly forwards the name parameter to guess_file_type, enabling name-aware file type detection. However, the docstring doesn't document this new parameter.

Apply this diff to update the docstring:

     Parameters:
     -----------
 
         - file (BinaryIO): A file-like object from which to extract metadata.
+        - name (Optional[str]): Optional filename to use for extension-based type inference.
 
     Returns:

📜 Review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 7743071 and 5007a2a.

📒 Files selected for processing (4)

• cognee/infrastructure/files/utils/get_file_metadata.py (3 hunks)
• cognee/infrastructure/files/utils/guess_file_type.py (3 hunks)
• cognee/infrastructure/loaders/core/audio_loader.py (1 hunks)
• cognee/modules/ingestion/data_types/BinaryData.py (1 hunks)

🧰 Additional context used

📓 Path-based instructions (2)

{cognee,cognee-mcp,distributed,examples,alembic}/**/*.py

📄 CodeRabbit inference engine (AGENTS.md)

{cognee,cognee-mcp,distributed,examples,alembic}/**/*.py: Use 4-space indentation; name modules and functions in snake_case; name classes in PascalCase (Python)
Adhere to ruff rules, including import hygiene and configured line length (100)
Keep Python lines ≤ 100 characters

Files:

• cognee/infrastructure/files/utils/get_file_metadata.py
• cognee/infrastructure/loaders/core/audio_loader.py
• cognee/infrastructure/files/utils/guess_file_type.py
• cognee/modules/ingestion/data_types/BinaryData.py

cognee/**/*.py

📄 CodeRabbit inference engine (AGENTS.md)

cognee/**/*.py: Public APIs in the core library should be type-annotated where practical
Prefer explicit, structured error handling and use shared logging utilities from cognee.shared.logging_utils

Files:

• cognee/infrastructure/files/utils/get_file_metadata.py
• cognee/infrastructure/loaders/core/audio_loader.py
• cognee/infrastructure/files/utils/guess_file_type.py
• cognee/modules/ingestion/data_types/BinaryData.py

🧬 Code graph analysis (3)

cognee/infrastructure/files/utils/get_file_metadata.py (2)

cognee/infrastructure/files/storage/FileBufferedReader.py (1)

• name (11-12)

cognee/infrastructure/files/utils/guess_file_type.py (1)

• guess_file_type (28-67)

cognee/infrastructure/files/utils/guess_file_type.py (1)

cognee/infrastructure/files/storage/FileBufferedReader.py (1)

• name (11-12)

cognee/modules/ingestion/data_types/BinaryData.py (2)

cognee/infrastructure/files/utils/get_file_metadata.py (1)

• get_file_metadata (30-79)

cognee/infrastructure/files/storage/FileBufferedReader.py (1)

• name (11-12)

🪛 Pylint (4.0.2)

cognee/infrastructure/files/utils/guess_file_type.py

[error] 1-1: Unrecognized option found: suggestion-mode

(E0015)

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (40)

• GitHub Check: Example Tests / Run Agentic Reasoning Tests
• GitHub Check: Operating System and Python Tests / Integration tests 3.12.x on windows-latest
• GitHub Check: Operating System and Python Tests / Unit tests 3.12.x on macos-15
• GitHub Check: Operating System and Python Tests / Hard Delete test 3.10.x on ubuntu-22.04
• GitHub Check: Example Tests / Run Agentic Reasoning Tests
• GitHub Check: Operating System and Python Tests / Integration tests 3.12.x on windows-latest
• GitHub Check: Operating System and Python Tests / Unit tests 3.12.x on macos-15
• GitHub Check: Operating System and Python Tests / Hard Delete test 3.10.x on ubuntu-22.04
• GitHub Check: Example Tests / Run Agentic Reasoning Tests
• GitHub Check: Operating System and Python Tests / Integration tests 3.12.x on windows-latest
• GitHub Check: Operating System and Python Tests / Unit tests 3.12.x on macos-15
• GitHub Check: Operating System and Python Tests / Hard Delete test 3.10.x on ubuntu-22.04
• GitHub Check: Example Tests / Run Agentic Reasoning Tests
• GitHub Check: Operating System and Python Tests / Integration tests 3.12.x on windows-latest
• GitHub Check: Operating System and Python Tests / Unit tests 3.12.x on macos-15
• GitHub Check: Operating System and Python Tests / Hard Delete test 3.10.x on ubuntu-22.04
• GitHub Check: Example Tests / Run Agentic Reasoning Tests
• GitHub Check: Operating System and Python Tests / Integration tests 3.12.x on windows-latest
• GitHub Check: Operating System and Python Tests / Unit tests 3.12.x on macos-15
• GitHub Check: Operating System and Python Tests / Hard Delete test 3.10.x on ubuntu-22.04
• GitHub Check: Example Tests / Run Agentic Reasoning Tests
• GitHub Check: Operating System and Python Tests / Integration tests 3.12.x on windows-latest
• GitHub Check: Operating System and Python Tests / Unit tests 3.12.x on macos-15
• GitHub Check: Operating System and Python Tests / Hard Delete test 3.10.x on ubuntu-22.04
• GitHub Check: Example Tests / Run Agentic Reasoning Tests
• GitHub Check: Operating System and Python Tests / Integration tests 3.12.x on windows-latest
• GitHub Check: Operating System and Python Tests / Unit tests 3.12.x on macos-15
• GitHub Check: Operating System and Python Tests / Hard Delete test 3.10.x on ubuntu-22.04
• GitHub Check: Example Tests / Run Agentic Reasoning Tests
• GitHub Check: Operating System and Python Tests / Integration tests 3.12.x on windows-latest
• GitHub Check: Operating System and Python Tests / Unit tests 3.12.x on macos-15
• GitHub Check: Operating System and Python Tests / Hard Delete test 3.10.x on ubuntu-22.04
• GitHub Check: Example Tests / Run Agentic Reasoning Tests
• GitHub Check: Operating System and Python Tests / Integration tests 3.12.x on windows-latest
• GitHub Check: Operating System and Python Tests / Unit tests 3.12.x on macos-15
• GitHub Check: Operating System and Python Tests / Hard Delete test 3.10.x on ubuntu-22.04
• GitHub Check: Example Tests / Run Agentic Reasoning Tests
• GitHub Check: Operating System and Python Tests / Integration tests 3.12.x on windows-latest
• GitHub Check: Operating System and Python Tests / Unit tests 3.12.x on macos-15
• GitHub Check: Operating System and Python Tests / Hard Delete test 3.10.x on ubuntu-22.04

🔇 Additional comments (3)

cognee/infrastructure/loaders/core/audio_loader.py (1)

45-45: LGTM! Good addition for WAV compatibility.

Adding "audio/x-wav" alongside "audio/wav" improves compatibility as WAV files may be served with either MIME type.

cognee/modules/ingestion/data_types/BinaryData.py (1)

31-36: LGTM! Correct integration of name-aware metadata retrieval.

The change properly passes self.name to get_file_metadata, enabling name-based file type detection. The existing fallback logic on lines 35-36 ensures the metadata name is always set.

cognee/infrastructure/files/utils/guess_file_type.py (1)

1-6: Remove unused imports: io, SpooledTemporaryFile, and Any.

These imports are not used in the file and should be removed to comply with import hygiene rules. Keep only the imports that are actively used: Path, BinaryIO, Optional, filetype, and Type.