fix: normalize Cypher search rows. #1725

ngyngcphu · 2025-11-02T14:08:33Z

Description

This PR resolves #1723. prepare_search_result now normalises tuple rows so scalar Cypher results stop triggering IndexError / AttributeError. Other search modes remain unchanged.

Type of Change

Bug fix (non-breaking change that fixes an issue)
New feature (non-breaking change that adds functionality)
Breaking change (fix or feature that would cause existing functionality to change)
Documentation update
Code refactoring
Performance improvement
Other (please specify):

Screenshots/Videos (if applicable)

Pre-submission Checklist

I have tested my changes thoroughly before submitting this PR
This PR contains minimal changes necessary to address the issue/feature
My code follows the project's coding standards and style guidelines
I have added tests that prove my fix is effective or that my feature works
I have added necessary documentation (if applicable)
All new and existing tests pass
I have searched existing PRs to ensure this change hasn't been submitted already
I have linked any relevant issues in the description
My commits have clear and descriptive messages

DCO Affirmation

I affirm that all code in every commit of this pull request conforms to the terms of the Topoteretes Developer Certificate of Origin.

Signed-off-by: ngyngcphu <[email protected]>

pull-checklist · 2025-11-02T14:08:37Z

Please make sure all the checkboxes are checked:

I have tested these changes locally.
I have reviewed the code changes.
I have added end-to-end and unit tests (if applicable).
I have updated the documentation and README.md file (if necessary).
I have removed unnecessary code and debug statements.
PR title is clear and follows the convention.
I have tagged reviewers or team members for feedback.

coderabbitai · 2025-11-02T14:08:44Z

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

✨ Finishing touches

🧪 Generate unit tests (beta)

Create PR with unit tests
Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

github-actions

Hello @ngyngcphu, thank you for submitting a PR! We will respond as soon as possible.

dexters1 · 2025-11-04T16:04:15Z

Hey @ngyngcphu thank you for your contribution! Could you also add a integration test for Cypher search with this case so we can be sure it won't break again?

Signed-off-by: ngyngcphu <[email protected]>

ngyngcphu · 2025-11-05T04:38:28Z

Hey @ngyngcphu thank you for your contribution! Could you also add a integration test for Cypher search with this case so we can be sure it won't break again?

Thanks @dexters1 for checking! I’ve added a integration test, please take a look.
I’ll summarize the result:

Before the change, running the test triggered 2 errors:

AttributeError: 'str' object has no attribute 'get'

Traceback (most recent call last):
  File "/Users/lap60627/Documents/cognee/cognee/tests/test_cypher_search.py", line 142, in <module>
    asyncio.run(main())
    ~~~~~~~~~~~^^^^^^^^
  File "/opt/homebrew/Cellar/[email protected]/3.13.5/Frameworks/Python.framework/Versions/3.13/lib/python3.13/asyncio/runners.py", line 195, in run
    return runner.run(main)
           ~~~~~~~~~~^^^^^^
  File "/opt/homebrew/Cellar/[email protected]/3.13.5/Frameworks/Python.framework/Versions/3.13/lib/python3.13/asyncio/runners.py", line 118, in run
    return self._loop.run_until_complete(task)
           ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^^^^^^
  File "/opt/homebrew/Cellar/[email protected]/3.13.5/Frameworks/Python.framework/Versions/3.13/lib/python3.13/asyncio/base_events.py", line 725, in run_until_complete
    return future.result()
           ~~~~~~~~~~~~~^^
  File "/Users/lap60627/Documents/cognee/cognee/tests/test_cypher_search.py", line 83, in main
    multi_column_raw = await cognee.search(
                       ^^^^^^^^^^^^^^^^^^^^
    ...<5 lines>...
    )
    ^
  File "/Users/lap60627/Documents/cognee/cognee/api/v1/search/search.py", line 188, in search
    filtered_search_results = await search_function(
                              ^^^^^^^^^^^^^^^^^^^^^^
    ...<14 lines>...
    )
    ^
  File "/Users/lap60627/Documents/cognee/cognee/modules/search/methods/search.py", line 129, in search
    await prepare_search_result(search_result) for search_result in search_results
    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/Users/lap60627/Documents/cognee/cognee/modules/search/utils/prepare_search_result.py", line 34, in prepare_search_result
    and context[0][1].get("relationship_name")
        ^^^^^^^^^^^^^^^^^
AttributeError: 'str' object has no attribute 'get'

IndexError: tuple index out of range

Traceback (most recent call last):
  File "/Users/lap60627/Documents/cognee/cognee/tests/test_cypher_search.py", line 142, in <module>
    asyncio.run(main())
    ~~~~~~~~~~~^^^^^^^^
  File "/opt/homebrew/Cellar/[email protected]/3.13.5/Frameworks/Python.framework/Versions/3.13/lib/python3.13/asyncio/runners.py", line 195, in run
    return runner.run(main)
           ~~~~~~~~~~^^^^^^
  File "/opt/homebrew/Cellar/[email protected]/3.13.5/Frameworks/Python.framework/Versions/3.13/lib/python3.13/asyncio/runners.py", line 118, in run
    return self._loop.run_until_complete(task)
           ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^^^^^^
  File "/opt/homebrew/Cellar/[email protected]/3.13.5/Frameworks/Python.framework/Versions/3.13/lib/python3.13/asyncio/base_events.py", line 725, in run_until_complete
    return future.result()
           ~~~~~~~~~~~~~^^
  File "/Users/lap60627/Documents/cognee/cognee/tests/test_cypher_search.py", line 122, in main
    context_only_raw = await cognee.search(
                       ^^^^^^^^^^^^^^^^^^^^
    ...<6 lines>...
    )
    ^
  File "/Users/lap60627/Documents/cognee/cognee/api/v1/search/search.py", line 188, in search
    filtered_search_results = await search_function(
                              ^^^^^^^^^^^^^^^^^^^^^^
    ...<14 lines>...
    )
    ^
  File "/Users/lap60627/Documents/cognee/cognee/modules/search/methods/search.py", line 129, in search
    await prepare_search_result(search_result) for search_result in search_results
    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/Users/lap60627/Documents/cognee/cognee/modules/search/utils/prepare_search_result.py", line 34, in prepare_search_result
    and context[0][1].get("relationship_name")
        ~~~~~~~~~~^^^
IndexError: tuple index out of range

After the change: it works correctly.

pazone · 2025-11-05T14:49:59Z

@ngyngcphu Please take a look at the alternative fix for that: #1739

ngyngcphu · 2025-11-05T15:26:36Z

@ngyngcphu Please take a look at the alternative fix for that: #1739

yeah, that way’s simpler, go with that PR. Thanks a lot.

pazone · 2025-11-06T13:21:36Z

Closing that one in favor of #1739. Thanks again @ngyngcphu for the great finding and the PR 👍

## Description Resolve issue with cypher search by encoding the return value from the cypher query into JSON. Uses fastapi json encoder ## Type of Change  - [x] Bug fix (non-breaking change that fixes an issue) - [ ] New feature (non-breaking change that adds functionality) - [ ] Breaking change (fix or feature that would cause existing functionality to change) - [ ] Documentation update - [ ] Code refactoring - [ ] Performance improvement - [ ] Other (please specify): ## Screenshots/Videos (if applicable) Example of result now with Cypher search with the following query "MATCH (src)-[rel]->(nbr) RETURN src, rel" on Simple example: ``` { "search_result":[ [ [ { "_id":{ "offset":0, "table":0 }, "_label":"Node", "id":"87372381-a9fe-5b82-9c92-3f5dbab1bc35", "name":"", "type":"DocumentChunk", "created_at":"2025-11-05T14:12:46.707597", "updated_at":"2025-11-05T14:12:54.801747", "properties":"{\"created_at\": 1762351945009, \"updated_at\": 1762351945009, \"ontology_valid\": false, \"version\": 1, \"topological_rank\": 0, \"metadata\": {\"index_fields\": [\"text\"]}, \"belongs_to_set\": null, \"text\": \"\\n Natural language processing (NLP) is an interdisciplinary\\n subfield of computer science and information retrieval.\\n \", \"chunk_size\": 48, \"chunk_index\": 0, \"cut_type\": \"paragraph_end\"}" }, { "_src":{ "offset":0, "table":0 }, "_dst":{ "offset":1, "table":0 }, "_label":"EDGE", "_id":{ "offset":0, "table":1 }, "relationship_name":"contains", "created_at":"2025-11-05T14:12:47.217590", "updated_at":"2025-11-05T14:12:55.193003", "properties":"{\"source_node_id\": \"87372381-a9fe-5b82-9c92-3f5dbab1bc35\", \"target_node_id\": \"bc338a39-64d6-549a-acec-da60846dd90d\", \"relationship_name\": \"contains\", \"updated_at\": \"2025-11-05 14:12:54\", \"relationship_type\": \"contains\", \"edge_text\": \"relationship_name: contains; entity_name: natural language processing (nlp); entity_description: An interdisciplinary subfield of computer science and information retrieval concerned with interactions between computers and human (natural) languages.\"}" } ] ] ], "dataset_id":"UUID(""af4b1c1c-90fc-59b7-952c-1da9bbde370c"")", "dataset_name":"main_dataset", "graphs":"None" } ``` Relates to #1725 Issue: #1723 ## Pre-submission Checklist  - [ ] **I have tested my changes thoroughly before submitting this PR** - [ ] **This PR contains minimal changes necessary to address the issue/feature** - [ ] My code follows the project's coding standards and style guidelines - [ ] I have added tests that prove my fix is effective or that my feature works - [ ] I have added necessary documentation (if applicable) - [ ] All new and existing tests pass - [ ] I have searched existing PRs to ensure this change hasn't been submitted already - [ ] I have linked any relevant issues in the description - [ ] My commits have clear and descriptive messages ## DCO Affirmation I affirm that all code in every commit of this pull request conforms to the terms of the Topoteretes Developer Certificate of Origin.

## Description Resolve issue with cypher search by encoding the return value from the cypher query into JSON. Uses fastapi json encoder ## Type of Change  - [x] Bug fix (non-breaking change that fixes an issue) - [ ] New feature (non-breaking change that adds functionality) - [ ] Breaking change (fix or feature that would cause existing functionality to change) - [ ] Documentation update - [ ] Code refactoring - [ ] Performance improvement - [ ] Other (please specify): ## Screenshots/Videos (if applicable) Example of result now with Cypher search with the following query "MATCH (src)-[rel]->(nbr) RETURN src, rel" on Simple example: ``` { "search_result":[ [ [ { "_id":{ "offset":0, "table":0 }, "_label":"Node", "id":"87372381-a9fe-5b82-9c92-3f5dbab1bc35", "name":"", "type":"DocumentChunk", "created_at":"2025-11-05T14:12:46.707597", "updated_at":"2025-11-05T14:12:54.801747", "properties":"{\"created_at\": 1762351945009, \"updated_at\": 1762351945009, \"ontology_valid\": false, \"version\": 1, \"topological_rank\": 0, \"metadata\": {\"index_fields\": [\"text\"]}, \"belongs_to_set\": null, \"text\": \"\\n Natural language processing (NLP) is an interdisciplinary\\n subfield of computer science and information retrieval.\\n \", \"chunk_size\": 48, \"chunk_index\": 0, \"cut_type\": \"paragraph_end\"}" }, { "_src":{ "offset":0, "table":0 }, "_dst":{ "offset":1, "table":0 }, "_label":"EDGE", "_id":{ "offset":0, "table":1 }, "relationship_name":"contains", "created_at":"2025-11-05T14:12:47.217590", "updated_at":"2025-11-05T14:12:55.193003", "properties":"{\"source_node_id\": \"87372381-a9fe-5b82-9c92-3f5dbab1bc35\", \"target_node_id\": \"bc338a39-64d6-549a-acec-da60846dd90d\", \"relationship_name\": \"contains\", \"updated_at\": \"2025-11-05 14:12:54\", \"relationship_type\": \"contains\", \"edge_text\": \"relationship_name: contains; entity_name: natural language processing (nlp); entity_description: An interdisciplinary subfield of computer science and information retrieval concerned with interactions between computers and human (natural) languages.\"}" } ] ] ], "dataset_id":"UUID(""af4b1c1c-90fc-59b7-952c-1da9bbde370c"")", "dataset_name":"main_dataset", "graphs":"None" } ``` Relates to #1725 Issue: #1723 ## Pre-submission Checklist  - [ ] **I have tested my changes thoroughly before submitting this PR** - [ ] **This PR contains minimal changes necessary to address the issue/feature** - [ ] My code follows the project's coding standards and style guidelines - [ ] I have added tests that prove my fix is effective or that my feature works - [ ] I have added necessary documentation (if applicable) - [ ] All new and existing tests pass - [ ] I have searched existing PRs to ensure this change hasn't been submitted already - [ ] I have linked any relevant issues in the description - [ ] My commits have clear and descriptive messages ## DCO Affirmation I affirm that all code in every commit of this pull request conforms to the terms of the Topoteretes Developer Certificate of Origin.  ## Description  ## Type of Change  - [ ] Bug fix (non-breaking change that fixes an issue) - [ ] New feature (non-breaking change that adds functionality) - [ ] Breaking change (fix or feature that would cause existing functionality to change) - [ ] Documentation update - [ ] Code refactoring - [ ] Performance improvement - [ ] Other (please specify): ## Screenshots/Videos (if applicable)  ## Pre-submission Checklist  - [ ] **I have tested my changes thoroughly before submitting this PR** - [ ] **This PR contains minimal changes necessary to address the issue/feature** - [ ] My code follows the project's coding standards and style guidelines - [ ] I have added tests that prove my fix is effective or that my feature works - [ ] I have added necessary documentation (if applicable) - [ ] All new and existing tests pass - [ ] I have searched existing PRs to ensure this change hasn't been submitted already - [ ] I have linked any relevant issues in the description - [ ] My commits have clear and descriptive messages ## DCO Affirmation I affirm that all code in every commit of this pull request conforms to the terms of the Topoteretes Developer Certificate of Origin.

fix(cypher-search): normalize rows in prepare_search_result

f93bdaa

Signed-off-by: ngyngcphu <[email protected]>

github-actions bot reviewed Nov 2, 2025

View reviewed changes

ngyngcphu changed the title ~~Normalize Cypher search rows.~~ fix: normalize Cypher search rows. Nov 2, 2025

Vasilije1990 requested review from dexters1 and pazone November 3, 2025 15:56

borisarzentar assigned ngyngcphu Nov 4, 2025

borisarzentar added the community-contribution Community contribution label label Nov 4, 2025

test(search): add cypher search regression coverage

9bac804

Signed-off-by: ngyngcphu <[email protected]>

pazone mentioned this pull request Nov 5, 2025

Fix cypher search #1739

Merged

16 tasks

pazone closed this Nov 6, 2025

pazone mentioned this pull request Nov 8, 2025

Cherry-pick: Fix cypher search (#1739) #1763

Merged

32 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

fix: normalize Cypher search rows. #1725

fix: normalize Cypher search rows. #1725

Uh oh!

ngyngcphu commented Nov 2, 2025 •

edited

Loading

Uh oh!

pull-checklist bot commented Nov 2, 2025

Uh oh!

coderabbitai bot commented Nov 2, 2025

Review skipped

Uh oh!

github-actions bot left a comment

Uh oh!

dexters1 commented Nov 4, 2025 •

edited

Loading

Uh oh!

ngyngcphu commented Nov 5, 2025

Uh oh!

pazone commented Nov 5, 2025

Uh oh!

ngyngcphu commented Nov 5, 2025

Uh oh!

pazone commented Nov 6, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

fix: normalize Cypher search rows. #1725

fix: normalize Cypher search rows. #1725

Uh oh!

Conversation

ngyngcphu commented Nov 2, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Type of Change

Screenshots/Videos (if applicable)

Pre-submission Checklist

DCO Affirmation

Uh oh!

pull-checklist bot commented Nov 2, 2025

Please make sure all the checkboxes are checked:

Uh oh!

coderabbitai bot commented Nov 2, 2025

Review skipped

Uh oh!

github-actions bot left a comment

Choose a reason for hiding this comment

Uh oh!

dexters1 commented Nov 4, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ngyngcphu commented Nov 5, 2025

Uh oh!

pazone commented Nov 5, 2025

Uh oh!

ngyngcphu commented Nov 5, 2025

Uh oh!

pazone commented Nov 6, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

ngyngcphu commented Nov 2, 2025 •

edited

Loading

dexters1 commented Nov 4, 2025 •

edited

Loading