-
Notifications
You must be signed in to change notification settings - Fork 963
Update aiofiles version constraint in pyproject.toml #1850
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Update aiofiles version constraint from <24.0.0 to <25.1.0 to resolve conflict with Microsoft agent-framework which requires aiofiles >=24.0.1. Fixes topoteretes#1829
Please make sure all the checkboxes are checked:
|
|
Important Review skippedReview was skipped due to path filters ⛔ Files ignored due to path filters (1)
CodeRabbit blocks several paths by default. You can override this behavior by explicitly including those paths in the path filters. For example, including You can disable this status message by setting the ✨ Finishing touches🧪 Generate unit tests (beta)
Tip 📝 Customizable high-level summaries are now available in beta!You can now customize how CodeRabbit generates the high-level summary in your pull requests — including its content, structure, tone, and formatting.
Example instruction:
Note: This feature is currently in beta for Pro-tier users, and pricing will be announced later. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hello @shanto12, thank you for submitting a PR! We will respond as soon as possible.
|
@siillee can you open a PR and check if tests are passing, and if so we can merge this one |
@Vasilije1990 Opened a PR on a new branch which triggered CI tests, everything seems to be fine EDIT: Still working on cleanly merging dev into this branch. After we merge PR about main/dev sync, then we can merge PR regarding this issue. |
|
Already resolved on the dev branch |
Description
This PR updates the
aiofilesversion constraint from<24.0.0to<25.1.0inpyproject.toml.Problem
Currently, cognee depends on
aiofiles>=23.2.1,<24.0.0, which conflicts with Microsoft agent-framework that requiresaiofiles>=24.0.1. This makes it impossible to use cognee alongside Microsoft agent-framework.Solution
Update the aiofiles upper bound to
<25.1.0to allow compatible versions while still maintaining an upper limit.Fixes #1829
Type of Change
Pre-submission Checklist