-
Notifications
You must be signed in to change notification settings - Fork 1.3k
Test audio image transcription #1911
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 1 commit
Commits
Show all changes
13 commits
Select commit
Hold shift + click to select a range
02b1778
Adding support for audio/image transcription for all other providers
rajeevrajeshuni 09fbf22
uv lock version revert
rajeevrajeshuni 57195fb
Merge branch 'dev' into issue-1767
rajeevrajeshuni 8e5f14d
resolving merge conflicts
rajeevrajeshuni d57d188
resolving merge conflicts
rajeevrajeshuni 6260f9e
strandardizing return type for transcription and some CR changes
rajeevrajeshuni 13c034e
Merge branch 'dev' into issue-1767
dexters1 a52873a
refactor: make return type mandatory for transcription
dexters1 d92d6b9
refactor: remove optional return value
dexters1 f2cb68d
refactor: use async image and transcription handling
dexters1 3e041ec
refactor: format code
dexters1 f27d07d
refactor: remove mandatory transcription and image methods in LLMInte…
dexters1 8027263
refactor: remove unused import
dexters1 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next
Next commit
Adding support for audio/image transcription for all other providers
- Loading branch information
commit 02b17786588b7be4c582a2fdfe93a5412c074cda
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Docstring inaccuracy:
create_transcriptreturn type and method ownership.The docstring states
create_transcript(input) -> BaseModelbut per theGenericAPIAdaptercontext, this method returnsTranscriptionReturnType. Also, bothcreate_transcriptandtranscribe_imageare inherited from the base class, not defined in this adapter.Public methods: - acreate_structured_output(text_input: str, system_prompt: str, response_model: Type[BaseModel]) -> BaseModel - - create_transcript(input) -> BaseModel: Transcribe audio files to text - - transcribe_image(input) -> BaseModel: Inherited from GenericAPIAdapter + + Inherited from GenericAPIAdapter: + - create_transcript(input) -> TranscriptionReturnType: Transcribe audio files to text + - transcribe_image(input) -> BaseModel: Transcribe image content """