-
Notifications
You must be signed in to change notification settings - Fork 1k
Feat/cog 1491 pipeline steps in eval #641
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
14 changes: 0 additions & 14 deletions
14
cognee/eval_framework/corpus_builder/task_getters/default_task_getter.py
This file was deleted.
Oops, something went wrong.
32 changes: 32 additions & 0 deletions
32
cognee/eval_framework/corpus_builder/task_getters/get_default_tasks_by_indices.py
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,32 @@ | ||
| from typing import List, Awaitable, Optional | ||
| from cognee.api.v1.cognify.cognify_v2 import get_default_tasks | ||
| from cognee.modules.pipelines.tasks.Task import Task | ||
| from cognee.modules.chunking.TextChunker import TextChunker | ||
|
|
||
|
|
||
| async def get_default_tasks_by_indices( | ||
| indices: List[int], chunk_size: int = None, chunker=TextChunker | ||
| ) -> List[Task]: | ||
| """Returns default tasks filtered by the provided indices.""" | ||
| all_tasks = await get_default_tasks(chunker=chunker, chunk_size=chunk_size) | ||
|
|
||
| if any(i < 0 or i >= len(all_tasks) for i in indices): | ||
| raise IndexError( | ||
| f"Task indices {indices} out of range. Valid range: 0-{len(all_tasks) - 1}" | ||
| ) | ||
|
|
||
| return [all_tasks[i] for i in indices] | ||
|
|
||
|
|
||
| async def get_no_summary_tasks(chunk_size: int = None, chunker=TextChunker) -> List[Task]: | ||
| """Returns default tasks without summarization tasks.""" | ||
| # Default tasks indices: 0=classify, 1=check_permissions, 2=extract_chunks, 3=extract_graph, 4=summarize, 5=add_data_points | ||
| return await get_default_tasks_by_indices( | ||
| [0, 1, 2, 3, 5], chunk_size=chunk_size, chunker=chunker | ||
|
Collaborator
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I am not sure I like the indices because whenever we change the default pipeline, we will have to update the index mapping. Fine for now but I think we will have to find a bit nicer solution |
||
| ) | ||
|
|
||
|
|
||
| async def get_just_chunks_tasks(chunk_size: int = None, chunker=TextChunker) -> List[Task]: | ||
| """Returns default tasks with only chunk extraction and data points addition.""" | ||
| # Default tasks indices: 0=classify, 1=check_permissions, 2=extract_chunks, 3=extract_graph, 4=summarize, 5=add_data_points | ||
| return await get_default_tasks_by_indices([0, 1, 2, 5], chunk_size=chunk_size, chunker=chunker) | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe OnlyChunks, its just naming so not that important