-
Notifications
You must be signed in to change notification settings - Fork 1k
feat: expose document deletion via the API #768
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: expose document deletion via the API #768
Conversation
Please make sure all the checkboxes are checked:
|
|
Important Review skippedReview was skipped due to path filters ⛔ Files ignored due to path filters (1)
CodeRabbit blocks several paths by default. You can override this behavior by explicitly including those paths in the path filters. For example, including You can disable this status message by setting the WalkthroughThe changes introduce a new router to the FastAPI application by importing the Changes
Sequence Diagram(s)sequenceDiagram
participant Client
participant FastAPI_App
participant DeleteRouter
Client->>FastAPI_App: Request to /api/v1/delete/...
FastAPI_App->>DeleteRouter: Route request to delete handler
DeleteRouter-->>FastAPI_App: Handle and return response
FastAPI_App-->>Client: Response
Poem
🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (1)
cognee/api/client.py (1)
168-168: Register delete router
The delete router is now included under/api/v1/deletewith thedeletetag. Please ensure this endpoint is covered by unit or integration tests and that the API documentation (e.g., README or OpenAPI spec) is updated accordingly.Would you like me to draft the test scaffolding or update the docs for this new endpoint?
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
⛔ Files ignored due to path filters (3)
cognee-mcp/pyproject.tomlis excluded by!**/*.tomlpoetry.lockis excluded by!**/*.lock,!**/*.lockpyproject.tomlis excluded by!**/*.toml
📒 Files selected for processing (1)
cognee/api/client.py(2 hunks)
🧰 Additional context used
🧬 Code Graph Analysis (1)
cognee/api/client.py (1)
cognee/api/v1/delete/routers/get_delete_router.py (1)
get_delete_router(14-77)
⏰ Context from checks skipped due to timeout of 90000ms (10)
- GitHub Check: End-to-End Tests / Run Telemetry Test
- GitHub Check: End-to-End Tests / Run Telemetry Pipeline Test
- GitHub Check: End-to-End Tests / Server Start Test
- GitHub Check: End-to-End Tests / S3 Bucket Test
- GitHub Check: End-to-End Tests / Deletion Test
- GitHub Check: End-to-End Tests / Deduplication Test
- GitHub Check: Basic Tests / Run Unit Tests
- GitHub Check: Basic Tests / Run Simple Examples
- GitHub Check: Basic Tests / Run Integration Tests
- GitHub Check: Basic Tests / Run Basic Graph Tests
🔇 Additional comments (1)
cognee/api/client.py (1)
16-16: Add delete router import
The newget_delete_routerimport is correctly placed alongside the other v1 router imports, keeping the pattern consistent.
Description
DCO Affirmation
I affirm that all code in every commit of this pull request conforms to the terms of the Topoteretes Developer Certificate of Origin.