-
Notifications
You must be signed in to change notification settings - Fork 1k
Remove orphaned filesystem reference. #772
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Please make sure all the checkboxes are checked:
|
WalkthroughThe Dockerfile was updated to remove the "filesystem" extra from the Changes
Possibly related PRs
Suggested labels
Suggested reviewers
Poem
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (1)
Dockerfile (1)
4-18: Consider refactoring the long extras list for maintainability
Embedding a long, whitespace‑separated string in a singleARGcan get brittle as extras change. As an optional improvement, you might:
- Move extras into
pyproject.tomlunder[tool.poetry.extras]and invokepoetry install --extras "$(poetry run poetry export -f json | jq -r '.metadata.extras | keys[]')"(or similar).- Extract the list into a separate file and copy it into the build context, then read it via
ARGorENV.This can make the Dockerfile cleaner and reduce the chance of typos when updating extras.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
Dockerfile(1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (10)
- GitHub Check: End-to-End Tests / Run Telemetry Test
- GitHub Check: End-to-End Tests / Run Telemetry Pipeline Test
- GitHub Check: End-to-End Tests / Server Start Test
- GitHub Check: End-to-End Tests / S3 Bucket Test
- GitHub Check: End-to-End Tests / Deletion Test
- GitHub Check: End-to-End Tests / Deduplication Test
- GitHub Check: Basic Tests / Run Unit Tests
- GitHub Check: Basic Tests / Run Simple Examples
- GitHub Check: Basic Tests / Run Integration Tests
- GitHub Check: Basic Tests / Run Basic Graph Tests
🔇 Additional comments (1)
Dockerfile (1)
8-8: 💡 Verification agent🧩 Analysis chain
Confirm safe removal of the
filesystemextra
Thefilesystemextra was dropped fromPOETRY_EXTRAS. Please ensure no code, tests, or transitive dependencies still rely on it (for example, inpyproject.toml, import statements, or CI scripts).You can run a quick grep to catch any lingering references:
🏁 Script executed:
#!/bin/bash # Verify no code or configuration still expects 'filesystem' rg -n "filesystem"Length of output: 367
Remove
filesystemextra from Helm Dockerfile
A lingering entry remains inhelm/Dockerfileon line 6. The other grep hits (adapter.py docstring and render_prompt comment) are non‑code references and can be ignored.• File: helm/Dockerfile, Line 6
- Remove
filesystemfrom the extras list.Diff:
- filesystem postgres weaviate qdrant neo4j falkordb milvus kuzu \ + postgres weaviate qdrant neo4j falkordb milvus kuzu \Likely an incorrect or invalid review comment.
Description
DCO Affirmation
I affirm that all code in every commit of this pull request conforms to the terms of the Topoteretes Developer Certificate of Origin.