feat: added util logger OS #841
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Please make sure all the checkboxes are checked:
|
Contributor
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the ✨ Finishing Touches🧪 Generate Unit Tests
🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
dexters1
reviewed
May 20, 2025
| return structlog.get_logger(name if name else __name__) | ||
| # Get a configured logger and log system information | ||
| logger = structlog.get_logger(name if name else __name__) | ||
| logger.info( |
Collaborator
There was a problem hiding this comment.
Would be good to also log Cognee version here
cognee/shared/logging_utils.py
Outdated
| COGNEE_VERSION = importlib.metadata.version("cognee") | ||
| except importlib.metadata.PackageNotFoundError: | ||
| # Fallback to hardcoded version if package metadata is not available | ||
| COGNEE_VERSION = "unknown" # |
dexters1
reviewed
May 20, 2025
cognee/shared/logging_utils.py
Outdated
| PYTHON_VERSION = platform.python_version() | ||
| STRUCTLOG_VERSION = structlog.__version__ | ||
| try: | ||
| COGNEE_VERSION = importlib.metadata.version("cognee") |
Collaborator
There was a problem hiding this comment.
Will expand on the version information for Cognee with a new commit on this PR.
So we also store version information on the package level (like structlog.__ version __ but cognee.__ version __)
And so we can differentiate between local Cognee library and pip installed Cognee library versions
…gnee local and pip libraries
dexters1
approved these changes
May 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
DCO Affirmation
I affirm that all code in every commit of this pull request conforms to the terms of the Topoteretes Developer Certificate of Origin.