Skip to content

Feature: Makes s3 pathway imports optional so cognee can run without s3fs #978

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Vasilije1990 merged 10 commits into from
Jun 13, 2025
Merged

Feature: Makes s3 pathway imports optional so cognee can run without s3fs #978

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
cdd8b3d
feat: makes s3fs optional in .add
hajdul88 Jun 12, 2025
f0847d6
fix: changes and repositions s3
hajdul88 Jun 12, 2025
7c11780
Merge branch 'dev' into feature/cog-2206-make-s3fs-imports-optional
hajdul88 Jun 12, 2025
5ac0abc
chore: deletes translation and related codeparts + old fetch secrets …
hajdul88 Jun 12, 2025
6090220
chore: sets s3fs and boto3 as optional dependencies
hajdul88 Jun 12, 2025
77d5a6a
Merge remote-tracking branch 'origin/dev' into feature/cog-2206-make-…
hajdul88 Jun 12, 2025
b1f32a2
chore: updates poetry and uv lock after dev merge
hajdul88 Jun 12, 2025
64f66fa
chore: updates test dependencies
hajdul88 Jun 12, 2025
8cdfcaf
Merge branch 'dev' into feature/cog-2206-make-s3fs-imports-optional
hajdul88 Jun 12, 2025
7d308fe
chore: adds s3fs note to pyproject.toml
hajdul88 Jun 13, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
chore: sets s3fs and boto3 as optional dependencies
  • Loading branch information
@hajdul88
hajdul88 committed Jun 12, 2025
commit 60902204d25c17efb030c698d12fb0ee9803e5c5
69 changes: 41 additions & 28 deletions poetry.lock
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 1 addition & 3 deletions pyproject.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,9 +27,6 @@ dependencies = [
"nltk==3.9.1",
"numpy>=1.26.4, <=2.1",
"pandas>=2.2.2",
# Note: New s3fs and boto3 versions don't work well together
# Always use comaptible fixed versions of these two dependencies
"s3fs[boto3]==2025.3.2",
"sqlalchemy==2.0.39",
"aiosqlite>=0.20.0,<0.21",
"tiktoken<=0.9.0",
Expand Down Expand Up @@ -112,6 +109,7 @@ gui = [
"qasync>=0.27.1,<0.28",
]
graphiti = ["graphiti-core>=0.7.0,<0.8"]
aws = ["s3fs[boto3]==2025.3.2"]
Copy link
Copy Markdown
Collaborator

@dexters1 dexters1 Jun 12, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add Note from above as well so we never forget this disaster that is s3fs with boto3 when not versioned together

Copy link
Copy Markdown
Collaborator Author

@hajdul88 hajdul88 Jun 13, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

True its better. will do thanks for pointing it out

Copy link
Copy Markdown
Collaborator Author

@hajdul88 hajdul88 Jun 13, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

dev = [
"pytest>=7.4.0,<8",
"pytest-cov>=6.1.1",
Expand Down
Loading
Loading