added code to deal with bucket names that have a period in them with ssl #104
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@tpyo any interest in merging this? I'm experiencing the same issue. |
There was a problem hiding this comment.
Might I recommend matching the style of the rest of this method?
if (S3::$useSSL && strstr($bucket, '.') !== false) return false;
|
@tpyo thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
libcurl3 was updated and now get's upset if an SSL connection is made to a bucked with a "." in the name. (I.E. it doesn't want to automatically extend SSL authentication down to sub-domains anymore)
This resolves the problem.