Skip to content

Don't take curl callback by ref #81

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 15, 2014
Merged

Don't take curl callback by ref #81

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1a33bb8
Don't take curl callback by ref
ptarjan May 15, 2014
42a9aa2
fix docblock
ptarjan May 15, 2014
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
Don't take curl callback by ref 
Changing these does nothing to the caller, why would you take them by ref? HHVM doesn't promote this to refs if they can't be modified: facebook/hhvm#2587
  • Loading branch information
@ptarjan
ptarjan committed May 15, 2014
commit 1a33bb8089a2b8d65579d15e86501aa842ad01b7
2 changes: 1 addition & 1 deletion S3.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2307,7 +2307,7 @@ private function __dnsBucketName($bucket)
* @param string &$data Data
Copy link

@ojhaujjwal ojhaujjwal May 15, 2014

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ptarjan
Hey Paul, I think you missed annotations.
@param string $data Data

* @return integer
*/
private function __responseHeaderCallback(&$curl, &$data)
private function __responseHeaderCallback($curl, $data)
{
if (($strlen = strlen($data)) <= 2) return $strlen;
if (substr($data, 0, 4) == 'HTTP')
Expand Down