react: Allow changing instance in uppy prop #1247
Merged
goto-bus-stop merged 2 commits intomasterfrom Jan 28, 2019
Merged
Conversation
Contributor
|
👍 Should we make a note in the docs, in bold, that uppy shouldn’t be initialized in |
Contributor
Author
|
Maybe we can also provide a Component to do something like <UppyProvider
initialize={uppy => {
uppy.use(Transloadit, {})
}}
render={uppy => (
<MyComponent uppy={uppy} />
)}
/>to manage the lifecycle of an Uppy instance. Or a const enhance = withUppy(uppy => {
uppy.use(Transloadit, {})
})
const MyComponent = ({ uppy }) => (
<Dashboard uppy={uppy} />
)
const MyComponentWithUppy = enhance(MyComponent)Or we could wait for React Hooks to be out of alpha, because I think it'll support the exact lifecycle that we need. |
|
@goto-bus-stop +1 for react-hooks support here! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When changing the Uppy instance, the components will uninstall the UI plugin from the old instance, and install it to the new instance.
One other thing that I wanted to do is warn when you create the Uppy instance in the render() method. that becomes harder when this use case is supported. If we didn't support changing instances, we could simply throw an error if the
uppyprop ever changes. If we support changing instances, I'm not sure how we'd detect Uppy instances being created in render().