Merged
Conversation
ifedapoolarewaju
force-pushed
the
custom-provider-example
branch
from
ea3d410 to
fe163d0
Compare
Contributor
There was a problem hiding this comment.
Set default state for Dropbox
Contributor
There was a problem hiding this comment.
this is unrelated but would it make sense to pass in the plugin and the Provider instance separately to provider Views? then we don't need the this[this.id] dance, people could just put it somewhere they like and then do new ProviderViews(this, provider)
Contributor
Author
There was a problem hiding this comment.
yes, I think that makes sense
Contributor
There was a problem hiding this comment.
sweet. adding to backlog so we can follow up in a separate PR
ifedapoolarewaju
force-pushed
the
custom-provider-example
branch
2 times, most recently
from
77f9611 to
2541275
Compare
ifedapoolarewaju
force-pushed
the
custom-provider-example
branch
from
2541275 to
faa6fbf
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.