Skip to content

Use bit shifting instead of math:power #5

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Use bit shifting instead of math:power #5

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
9981476
Use bit shifting instead of math:power
luuhq Feb 9, 2013
d72c0c2
format code
luuhq Feb 12, 2013
acf4cde
merged changes
luuhq Mar 29, 2013
9230dcb
Use crypto:rand_uniform and removed `-1`
luuhq Mar 29, 2013
b2a15bc
Update uuid.erl
luuhq Mar 29, 2013
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Use crypto:rand_uniform and removed -1 
Since crypto:rand_uniform returns N, with Lo <= N < Hi, we don't need -1 here.
  • Loading branch information
@luuhq
luuhq committed Mar 29, 2013
commit 9230dcb58aaceb0acb67b84531a69f5c3668b965
8 changes: 4 additions & 4 deletions uuid.erl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,10 +33,10 @@

% Generates a random binary UUID.
v4() ->
v4(random:uniform(1 bsl 48) - 1,
random:uniform(1 bsl 12) - 1,
random:uniform(1 bsl 32) - 1,
random:uniform(1 bsl 30) - 1).
v4(crypto:rand_uniform(1 bsl 48),
crypto:rand_uniform(1 bsl 12),
crypto:rand_uniform(1 bsl 32),
crypto:rand_uniform(1 bsl 30)).

v4(R1, R2, R3, R4) ->
<<R1:48, 4:4, R2:12, 2:2, R3:32, R4: 30>>.
Expand Down