update documentation to include example of how to end stream#691
Open
markwbrown wants to merge 1 commit intotrentm:masterfrom
Open
update documentation to include example of how to end stream#691markwbrown wants to merge 1 commit intotrentm:masterfrom
markwbrown wants to merge 1 commit intotrentm:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I'm not sure what JSSTYLED was supposed to be doing, but the close stream function has been commented out since #1a916f6ad7b1e731d1ea04ad4e44cc1db2cf4e94. In the absence of that getting changed, I think this documentation can help people with ending a stream. I found this useful in a node application to push its own logs over to s3.