Skip to content

fix: bump moment to 2.29.4 in optionalDependencies#701

Open
richardkazuomiller wants to merge 1 commit intotrentm:masterfrom
richardkazuomiller:moment-optional-dep
Open

fix: bump moment to 2.29.4 in optionalDependencies#701
richardkazuomiller wants to merge 1 commit intotrentm:masterfrom
richardkazuomiller:moment-optional-dep

Conversation

@richardkazuomiller
Copy link
Copy Markdown

Fixes #692

The order of the dependencies is changed because npm install --save-optional x puts dependencies in alphabetical order.

@richardkazuomiller
Copy link
Copy Markdown
Author

@trentm Are you interested in this update or shall we close it?

@hoangquanglam
Copy link
Copy Markdown

@eexit
Copy link
Copy Markdown

eexit commented Nov 6, 2022

Hello, any update on this?

Thanks!

Edit: I found a workaround:

yarn remove bunyan --save
yarn add bunyan --save --ignore-optionals
yarn list v1.22.18
warning Filtering by arguments is deprecated. Please use the pattern option instead.
└─ moment@2.29.4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Update version of moment to fix GHSA-wc69-rhjr-hc9g (CVE-2022-31129)

3 participants