Instantiating the Error class to call prepareStackTrace#715
Open
danilobatistaqueiroz wants to merge 1 commit intotrentm:masterfrom
Open
Instantiating the Error class to call prepareStackTrace#715danilobatistaqueiroz wants to merge 1 commit intotrentm:masterfrom
danilobatistaqueiroz wants to merge 1 commit intotrentm:masterfrom
Conversation
|
Hi @trentm - would it be possible to get this reviewed and published? |
Owner
|
Looking. |
|
Hi @trentm any update on the same... |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Using src:true isn't work in new Node versions.
Fixes: #714
As of Node 20.1.0 if you don't call
new Error()the methodprepareStackTraceisn't called.Nodejs issue: nodejs/node#49681
Before the correction, using a Node version starting from 20.1.0, log.info returns an empty src.
TESTS
There is a test for src named:
src.test.jsand using node version 20.1.0 or latter it breaks at line 45.