fix: update deps and tests for compatibility with tap v21#732
Open
jdinsel-xealth wants to merge 2 commits intotrentm:masterfrom
Open
fix: update deps and tests for compatibility with tap v21#732jdinsel-xealth wants to merge 2 commits intotrentm:masterfrom
jdinsel-xealth wants to merge 2 commits intotrentm:masterfrom
Conversation
- Replace t.ifError() with t.error() across all test files (removed in tap v16+) - Add missing devDependencies: vasync, verror (used in tests but not declared) - Add exeunt as a runtime dependency (required by bin/bunyan) - Replace optional mv dependency with built-in fs.rename in RotatingFileStream; mv was only used for same-filesystem log rotation renames, making it redundant
Author
|
If anyone finds this and is looking for a similar solution, the fork at https://github.com/expo/node-bunyan (https://www.npmjs.com/package/@expo/bunyan) seems like a good alternative. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Story
Updates dependencies and replaces
mvwith built infs.renamegiving some more life to the Bunyan project. Themvpackage has a known issue and was last released 11 years ago.When I started the work, all of the test cases were failing. This pull request includes fixes.