Skip to content

Fixes enable/disable timepicker #623

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 9, 2013
Merged

Fixes enable/disable timepicker #623

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e96f726
Fixes enable/disable timepicker
althaus Aug 9, 2013
bc166e4
Fixed exception thrown by onTimeChange
althaus Aug 9, 2013
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Fixed exception thrown by onTimeChange 
After disabling a timepicker an exception is thrown, if you close the now timepicker-less datepicker.
  • Loading branch information
@althaus
althaus committed Aug 9, 2013
commit bc166e45e35fa89ee53a502dfe9d4a09d88567ab
3 changes: 3 additions & 0 deletions src/jquery-ui-timepicker-addon.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -702,6 +702,9 @@
* on time change is also called when the time is updated in the text field
*/
_onTimeChange: function () {
if (!this._defaults.showTimepicker) {
return;
}
var hour = (this.hour_slider) ? this.control.value(this, this.hour_slider, 'hour') : false,
minute = (this.minute_slider) ? this.control.value(this, this.minute_slider, 'minute') : false,
second = (this.second_slider) ? this.control.value(this, this.second_slider, 'second') : false,
Expand Down