-
-
Notifications
You must be signed in to change notification settings - Fork 828
feat(helm): support topology spread constraints #2560
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -184,6 +184,10 @@ spec: | |
value: {{ default "10Gi" .Values.supervisor.config.kubernetes.ephemeralStorageSizeLimit | quote }} | ||
- name: KUBERNETES_EPHEMERAL_STORAGE_SIZE_REQUEST | ||
value: {{ default "2Gi" .Values.supervisor.config.kubernetes.ephemeralStorageSizeRequest | quote }} | ||
{{- with .Values.supervisor.config.kubernetes.topologySpreadConstraints }} | ||
- name: KUBERNETES_TOPOLOGY_SPREAD_CONSTRAINTS | ||
value: {{ tpl (toYaml .) $ | toJson | quote }} | ||
{{- end }} | ||
# Pod cleaner configuration | ||
- name: POD_CLEANER_ENABLED | ||
value: {{ .Values.supervisor.config.podCleaner.enabled | quote }} | ||
|
@@ -272,6 +276,10 @@ spec: | |
tolerations: | ||
{{- toYaml . | nindent 8 }} | ||
{{- end }} | ||
{{- with .Values.supervisor.topologySpreadConstraints }} | ||
topologySpreadConstraints: | ||
{{- tpl (toYaml .) $ | nindent 8 }} | ||
{{- end }} | ||
Comment on lines
+279
to
+282
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. It seems that supervisor deployment is locked to a replica count of 1. Curious what the reason for that is? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. The reason I am asking is, although it's good to have the topology spread constraints config surfaced to users, it's likely going to be ineffectual because of the replica count being locked to 1. |
||
--- | ||
apiVersion: v1 | ||
kind: Service | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I realize I requested adding support for topology spread constraints for the jobs too but I am not sure if, in practice, it would be effective, since only a single replica of a job is running at any given time, correct? If so, I suggest removing this for now.