Use Supplier to list datasets in BigQuery #22059
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We shouldn't list datasets when case insensitive name matching is disabled.
nineinchnick
approved these changes
May 22, 2024
findepi
approved these changes
May 22, 2024
|
|
||
| Map<String, Optional<RemoteDatabaseObject>> mapping = new HashMap<>(); | ||
| for (DatasetId datasetId : datasetIds) { | ||
| for (DatasetId datasetId : datasetIds.get()) { |
Member
There was a problem hiding this comment.
Can we call listDatasetIds(projectId) instead of passing this as an argument?
Member
Author
There was a problem hiding this comment.
This method is called from the following place (in schemas loop):
Such change will cause slow metadata listing we fixed in #22033
Maybe, worth leaving a code comment?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Release notes
(x) This is not user-visible or is docs only, and no release notes are required.