Implement streamRelationColumns in Cassandra #22146
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wendigo
reviewed
May 27, 2024
Contributor
There was a problem hiding this comment.
it would be much more readable if we had a SchemaTablePrefix(Optional schema) constructor. At first glance I have no idea what's happening here because two different constructors are involved.
.orElse(new SchemaTablePrefix()); would be better I think.
wendigo
approved these changes
May 27, 2024
ebyhr
force-pushed
the
ebi/cassandra-list-columns
branch
from
bd5d5c5 to
e1a1294
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Release notes
(x) This is not user-visible or is docs only, and no release notes are required.