Add extra diagnostics to pinpoint issue with missing spoolingOutputStats #22170
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
losipiuk
added
no-release-notes
findepi
approved these changes
May 28, 2024
Log was emitted for cases when task was failed, and this is not the case when we care about sate of spoolingOutputStats.
losipiuk
force-pushed
the
lo/spooling-not-found-debug
branch
from
0f82629 to
7de50e4
Compare
dekimir
reviewed
Jun 1, 2024
| if (updated && newValue.taskStatus().getState().isDone()) { | ||
| taskStatusFetcher.updateTaskStatus(newTaskInfo.taskStatus()); | ||
| finalTaskInfo.compareAndSet(Optional.empty(), Optional.of(newValue)); | ||
| boolean finalTaskInfoUpdated = finalTaskInfo.compareAndSet(Optional.empty(), Optional.of(newValue)); |
Contributor
There was a problem hiding this comment.
It seems to me that we should just refuse to update finalTaskInfo here if missingSpoolingOutputStats is true. Updating it will trigger the listener registered here:
which will eventually trigger this line:
and that's forbidden when the
spoolingOutputStats is missing.
Storing a null stats here guarantees that the null check will fail in retrieveAndDropSpoolingOutputStats().
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Additional context and related issues
Release notes
( ) This is not user-visible or is docs only, and no release notes are required.
( ) Release notes are required. Please propose a release note for me.
( ) Release notes are required, with the following suggested text: