Skip to content

[BACKEND] Deprecate MMAv1; fallback to FMA for computeCapability < 80#5066

Merged
Jokeren merged 3 commits intomainfrom
keren/disable-mmav1
Nov 5, 2024
Merged

[BACKEND] Deprecate MMAv1; fallback to FMA for computeCapability < 80#5066
Jokeren merged 3 commits intomainfrom
keren/disable-mmav1

Conversation

@Jokeren
Copy link
Copy Markdown
Contributor

@Jokeren Jokeren commented Nov 5, 2024

No description provided.

@Jokeren Jokeren marked this pull request as ready for review November 5, 2024 02:51
@Jokeren Jokeren requested a review from ptillet as a code owner November 5, 2024 02:51
@ThomasRaoux
Copy link
Copy Markdown
Collaborator

Can you update the readme?

@Jokeren
Copy link
Copy Markdown
Contributor Author

Jokeren commented Nov 5, 2024

Updated

@Isotr0py
Copy link
Copy Markdown

Isotr0py commented Mar 3, 2025

Hi @Jokeren @ThomasRaoux, I noticed that the supported Nvidia GPU in README was bumped to requiring cc 8.0+ in this PR.

Did it mean the Volta and Turing support including FMA fallback will be removed in the future? Or did it just mean MMA will be disabled on pre-Ampere GPUs with FMA fallback?

I used T4 to run the triton core tests and it passed with latest triton 0.3.2, but I'm not sure if it just still worked by coincidence since it's no longer in the supported hardware list.

@Jokeren
Copy link
Copy Markdown
Contributor Author

Jokeren commented Mar 3, 2025

Did it mean the Volta and Turing support including FMA fallback will be removed in the future? Or did it just mean MMA will be disabled on pre-Ampere GPUs with FMA fallback?

IMO, community contribution to pre ampere architectures with MMA is welcome if it doesn't break backward compatibility. The FMA code path will still be maintained in triton/main.

@Isotr0py
Copy link
Copy Markdown

Isotr0py commented Mar 3, 2025

@Jokeren Got it! Thanks for your explanation!

@ThomasRaoux
Copy link
Copy Markdown
Collaborator

yes we are not going to break support for older platform but the support will be best effort and won't be tested on our side. As Keren mentioned contributions are welcome to fix older platform however we are unlikely to accept complex performance related patches for those.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants