Skip to content

Conversation

@nautilus7
Copy link
Contributor

@nautilus7 nautilus7 commented May 24, 2023

Description

Port Frigate to new common. This is a draft PR to for testing. Depending on the errors generated, I may or may not be able to fix them (I don't have any experience), so help might be needed from team members.

⚒️ Fixes #

⚙️ Type of change

  • ⚙️ Feature/App addition
  • 🪛 Bugfix
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • 🔃 Refactor of current code

🧪 How Has This Been Tested?

📃 Notes:

✔️ Checklist:

  • ⚖️ My code follows the style guidelines of this project
  • 👀 I have performed a self-review of my own code
  • #️⃣ I have commented my code, particularly in hard-to-understand areas
  • 📄 I have made corresponding changes to the documentation
  • ⚠️ My changes generate no new warnings
  • 🧪 I have added tests to this description that prove my fix is effective or that my feature works
  • ⬆️ I increased versions for any altered app according to semantic versioning

➕ App addition

If this PR is an app addition please make sure you have done the following.

  • 🪞 I have opened a PR on truecharts/containers adding the container to TrueCharts mirror repo.
  • 🖼️ I have added an icon in the Chart's root directory called icon.png

Please don't blindly check all the boxes. Read them and only check those that apply.
Those checkboxes are there for the reviewer to see what is this all about and
the status of this PR with a quick glance.

@CLAassistant
Copy link

CLAassistant commented May 24, 2023

CLA assistant check
All committers have signed the CLA.

Copy link
Collaborator

@StevenMcElligott StevenMcElligott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs these changes for the configmaps

@nautilus7 nautilus7 marked this pull request as ready for review May 30, 2023 12:26
@nautilus7 nautilus7 requested a review from a team May 30, 2023 12:26
@nautilus7 nautilus7 requested a review from PrivatePuffin as a code owner May 30, 2023 12:26
@StevenMcElligott
Copy link
Collaborator

Why is this skipping chart-test ?

@stavros-k
Copy link
Collaborator

Why is this skipping chart-test ?

Exlcuded cause it needs mqtt setup to actually run

@stavros-k
Copy link
Collaborator

@all-contributors please add @nautilus7 for code

@stavros-k stavros-k merged commit 617f9d8 into trueforge-org:master Jun 1, 2023
@allcontributors
Copy link
Contributor

@stavros-k

I've put up a pull request to add @nautilus7! 🎉

stavros-k pushed a commit that referenced this pull request Jun 1, 2023
Adds @nautilus7 as a contributor for code.

This was requested by stavros-k [in this
comment](#9141 (comment))

[skip ci]

---------

Co-authored-by: allcontributors[bot] <46447321+allcontributors[bot]@users.noreply.github.com>
@truecharts-admin
Copy link
Collaborator

This PR is locked to prevent necro-posting on closed PRs. Please create a issue or contact staff on discord if you want to further discuss this

@trueforge-org trueforge-org locked as resolved and limited conversation to collaborators Jun 9, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants