Skip to content

Conversation

@nautilus7
Copy link
Contributor

@nautilus7 nautilus7 commented Jun 6, 2023

Description
I added the newly introduced settings in frigate 0.12 and updated as necessary the existing ones. Some parts of the code need to be carefully reviewed by a more experienced developer, as this is my first time dealing with so extensive changes in a chart (It was a chance for me learning some of the codebase of truecharts).

⚒️ Fixes #

⚙️ Type of change

  • ⚙️ Feature/App addition
  • 🪛 Bugfix
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • 🔃 Refactor of current code

🧪 How Has This Been Tested?

📃 Notes:

✔️ Checklist:

  • ⚖️ My code follows the style guidelines of this project
  • 👀 I have performed a self-review of my own code
  • #️⃣ I have commented my code, particularly in hard-to-understand areas
  • 📄 I have made corresponding changes to the documentation
  • ⚠️ My changes generate no new warnings
  • 🧪 I have added tests to this description that prove my fix is effective or that my feature works
  • ⬆️ I increased versions for any altered app according to semantic versioning

➕ App addition

If this PR is an app addition please make sure you have done the following.

  • 🪞 I have opened a PR on truecharts/containers adding the container to TrueCharts mirror repo.
  • 🖼️ I have added an icon in the Chart's root directory called icon.png

Please don't blindly check all the boxes. Read them and only check those that apply.
Those checkboxes are there for the reviewer to see what is this all about and
the status of this PR with a quick glance.

@nautilus7 nautilus7 changed the title DNM fix(frigate) Various updates for 0.12 - still testing [DNM] fix(frigate) Various updates for frigate 0.12 - testing Jun 6, 2023
@nautilus7 nautilus7 changed the title [DNM] fix(frigate) Various updates for frigate 0.12 - testing [DNM] fix(frigate) Various updates for frigate 0.12 Jun 10, 2023
@nautilus7 nautilus7 marked this pull request as ready for review June 10, 2023 16:25
@nautilus7 nautilus7 requested a review from a team June 10, 2023 16:25
@nautilus7 nautilus7 requested a review from PrivatePuffin as a code owner June 10, 2023 16:25
@nautilus7
Copy link
Contributor Author

nautilus7 commented Jun 10, 2023

The "go2rtc" settings section in all files need to be thoroughly reviewed.

https://github.com/truecharts/charts/pull/9448/files#diff-3b05307860dda196e0b2d541f45a883e71008a0f43a9d455911a694288392a43R334-R351

https://github.com/truecharts/charts/pull/9448/files#diff-a448fd31ae0a3000a57bdea03eb6d065a89ba657d60b1f62473deeba316c9a41R418-R433

The respective part in the questions.yaml should be ok.

Also I had trouble getting the CI to pass with this https://github.com/truecharts/charts/pull/9448/files#diff-a448fd31ae0a3000a57bdea03eb6d065a89ba657d60b1f62473deeba316c9a41R545 new setting enabled, so I had to commented it out. Don't know what's wrong. Maybe there is a bug in frigate regarding this. I'll have to ask its devs.

@nautilus7
Copy link
Contributor Author

Closing as there will be a much simpler way to handle the whole configuration from inside the UI now.

@nautilus7 nautilus7 closed this Jun 10, 2023
@PrivatePuffin
Copy link
Member

Closing as there will be a much simpler way to handle the whole configuration from inside the UI now.

What the heck are you refering to?

@stavros-k
Copy link
Collaborator

Closing as there will be a much simpler way to handle the whole configuration from inside the UI now.

What the heck are you refering to?

#9575

@nautilus7
Copy link
Contributor Author

@Ornias1993 you should express yourself in a more polite way, especially when YOU have no idea what you're talking about. Incubator is not your thing, per your saying, anyway...

@truecharts-admin
Copy link
Collaborator

This PR is locked to prevent necro-posting on closed PRs. Please create a issue or contact staff on discord if you want to further discuss this

@trueforge-org trueforge-org locked as resolved and limited conversation to collaborators Jun 19, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants