fix: attempt to install specified pnpm version #243
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
puzzler7
commented
May 16, 2024
| shell: bash | ||
| run: | | ||
| if [ -e package.json ] && command -v jq >/dev/null; then | ||
| PNPM_VERSION=$(jq -r '.packageManager|split("@")[1]' package.json || echo "") |
Collaborator
Author
There was a problem hiding this comment.
Splitting because the format in package.json is pnpm@version-num and we just need the version number.
TylerJang27
approved these changes
May 16, 2024
Contributor
TylerJang27
left a comment
TylerJang27
left a comment
There was a problem hiding this comment.
LGTM. Would be nice to at a trunk tools install jq dependency at some point for this
puzzler7
deleted the
maverick/trunk-11473-install-correct-pnpm-version-in-trunk-action
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, we only install the latest pnpm version, which fails if the user has specified a pnpm version under
packageManagerin their package.json. This PR changes that to attempt to parse the version out of the package.json before defaulting to latest.The
pnpm/action-setupaction does have logic for parsing the version out of the package.json, but we cannot provide both an version and a version in the package.json, or it will fail (source link).Tested manually, both with and without the
packageManagerfield.