Skip to content

Conversation

@simonostendorf
Copy link
Contributor

This adds the input parameter labels.

I think this is a needed parameter because some repos have different label schemas than "trunk".

Example: I would like to add "area: dependencies" as label instead of "trunk".

@simonostendorf simonostendorf force-pushed the feat/upgrade/add-labels-input-parameter branch 2 times, most recently from 656ba8d to c84bc61 Compare September 4, 2024 20:03
@simonostendorf simonostendorf force-pushed the feat/upgrade/add-labels-input-parameter branch from c84bc61 to e875575 Compare September 9, 2024 18:12
@simonostendorf simonostendorf force-pushed the feat/upgrade/add-labels-input-parameter branch 2 times, most recently from 5910d94 to 64eefac Compare September 28, 2024 15:22
@simonostendorf simonostendorf force-pushed the feat/upgrade/add-labels-input-parameter branch from 64eefac to 47c3394 Compare October 6, 2024 15:44
@simonostendorf simonostendorf force-pushed the feat/upgrade/add-labels-input-parameter branch from 47c3394 to 3661789 Compare October 10, 2024 11:40
@EliSchleifer EliSchleifer self-requested a review October 10, 2024 16:22
@simonostendorf
Copy link
Contributor Author

Thanks @EliSchleifer for starting the pipelines. Are the failed workflows caused by my changes or are there other errors?

@EliSchleifer
Copy link
Member

Thanks @EliSchleifer for starting the pipelines. Are the failed workflows caused by my changes or are there other errors?

Those are pre-existing issues. This looks good to go.

@EliSchleifer EliSchleifer enabled auto-merge (squash) October 10, 2024 17:21
Copy link
Member

@EliSchleifer EliSchleifer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@EliSchleifer EliSchleifer merged commit b0ffb2e into trunk-io:main Oct 10, 2024
@EliSchleifer
Copy link
Member

Thanks for the contribution.

@simonostendorf simonostendorf deleted the feat/upgrade/add-labels-input-parameter branch October 10, 2024 20:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants