feat(upgrade): update create-pull-request to v7 and add sign-commits input parameter #263
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
det
approved these changes
Oct 28, 2024
Contributor
det
left a comment
det
left a comment
There was a problem hiding this comment.
LGTM. Thanks for the contribution!
Contributor
Author
@det thanks. Is there any chance to get this merged and released? |
simonostendorf
force-pushed
the
feat/upgrade/add-sign-commits-input-parameter
branch
from
eb3967b to
2a17a09
Compare
|
It would be great if this feature could be merged. 👍🏻 |
Member
|
Looking at this now...hope we can verify tests and get this in. Sorry for the delay |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I want to use automated trunk updates in a repository where all commits need to be signed.
So I thought about adding it to the github action because the
create-pull-requestaction that is used here has support for signed commits using GitHub API starting with v7.So I upgraded
create-pull-requestto v7 and added a new input value to enable signing.I am using my forked action currently and its working fine but I would like to contribute this to you :)