fix: only post comment when checking PRs #279
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
puzzler7
requested review from
TylerJang27 and
Copilot
and removed request for
Copilot
There was a problem hiding this comment.
Pull Request Overview
This PR updates the comment posting behavior so that comments are only posted when checking pull requests and not during merge checks, and it adds a continue-on-error feature to prevent future errors from blocking execution.
- Updated the if condition for the "Find Comment" and "Post comment" steps to include a check for TRUNK_CHECK_MODE being "pull_request".
- Added the "continue-on-error: true" property to both steps.
action.yaml
Outdated
| - name: Find Comment | ||
| uses: peter-evans/find-comment@v3 | ||
| if: inputs.check-mode == 'payload' && env.INPUT_GITHUB_TOKEN | ||
| if: |
There was a problem hiding this comment.
The multiline if condition may not be interpreted as a single string expression by GitHub Actions. Consider using a folded scalar (e.g., using > to create a multiline string) to ensure the entire condition is processed correctly.
Suggested change
| if: | |
| if: > |
action.yaml
Outdated
| - name: Post comment | ||
| uses: peter-evans/create-or-update-comment@v4 | ||
| if: inputs.check-mode == 'payload' && env.INPUT_GITHUB_TOKEN | ||
| if: |
There was a problem hiding this comment.
Similarly, the multiline if condition here might lead to YAML parsing issues. Use a folded scalar to combine the condition into a single string to ensure proper evaluation.
Suggested change
| if: | |
| if: > |
puzzler7
force-pushed
the
maverick/dont-comment-on-merge
branch
from
777f4e6 to
936431b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes the comment posting so it only happens on checking PRs, not on checking merge. Additionally, adds a continue on error, so that if there are future errors, they aren't blocking.