Skip to content

Conversation

@sosthene-nitrokey
Copy link
Contributor

@sosthene-nitrokey sosthene-nitrokey commented Apr 12, 2023

Fixes #35

Copy link
Member

@robin-nitrokey robin-nitrokey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@sosthene-nitrokey sosthene-nitrokey force-pushed the remove-dir-all-where-recurse branch from 5ea4b14 to 65ea875 Compare April 12, 2023 09:16
@szszszsz szszszsz changed the title Fix #35 Correct remove_dir_all_where recursion handling / Fix #35 Apr 12, 2023
@sosthene-nitrokey sosthene-nitrokey force-pushed the remove-dir-all-where-recurse branch from 65ea875 to aed4b1c Compare April 19, 2023 14:13
Fixes trussed-dev#35

`remove_dir_all_where` correctly handles the case where a file in the directory was skipped, but not if a subdirectory was skipped.
This commit fixes it
@sosthene-nitrokey sosthene-nitrokey force-pushed the remove-dir-all-where-recurse branch from aed4b1c to 388eeb8 Compare April 20, 2023 07:15
@sosthene-nitrokey sosthene-nitrokey merged commit 154e054 into trussed-dev:main Jun 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

remove_dir_all_where does not properly handle recursion

2 participants