Decode char arrays to slice instead of vec #293
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* metadata decoding no longer makes an extra copy * ancestral/derived states of sites/mutations no longer make extra copies. BREAKING CHANGE: return types of SiteTable::ancestral_state and MutationTable:derived_state now return slices instead of vectors.
molpopgen
force-pushed
the
metadata_decoding_perf
branch
from
bf65626 to
53adef2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
copy
no longer make extra copies.
BREAKING CHANGE: return types of
SiteTable::ancestral_state and
MutationTable:derived_state now return
slices instead of vectors.