Skip to content

refactor row access #351

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 31, 2022
Merged

refactor row access #351

merged 1 commit into from
Oct 31, 2022

Conversation

@molpopgen
Copy link
Member

@molpopgen molpopgen commented Oct 30, 2022

  • refactor: table row getters return None for indexes out of range
  • fix node_table.rs
  • fix edge_table.rs
  • fix mig table
  • ind tqable
  • pos table
  • mutation table
  • "non-controversial" changes to tree interface source file
  • req'd fixes in tree interface source file

@molpopgen molpopgen force-pushed the refactor_row_access branch 2 times, most recently from 0155002 to f984006 Compare October 31, 2022 00:21
@molpopgen
refactor: return None for out-of-range row indexes, part II.
11e6c4c 
* table column getters now return Option instead of Result
* tree getters now return Option instead of Result
* Tree functions returning iterators now return
  Option<impl Iterator<...>> instead of Result<impl Iterator<...>>.
* Update documentation

BREAKING CHANGE: return value changes
@molpopgen molpopgen force-pushed the refactor_row_access branch from f984006 to 11e6c4c Compare October 31, 2022 00:26
@molpopgen molpopgen marked this pull request as ready for review October 31, 2022 00:33
@molpopgen molpopgen merged commit cb580f1 into main Oct 31, 2022
@molpopgen molpopgen deleted the refactor_row_access branch October 31, 2022 00:33
@molpopgen molpopgen mentioned this pull request Oct 31, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@molpopgen