Skip to content

Return &str from provenance table getters #403

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Nov 9, 2022
Merged

Return &str from provenance table getters #403

merged 2 commits into from
Nov 9, 2022

Conversation

@molpopgen
Copy link
Member

@molpopgen molpopgen commented Nov 9, 2022

  • refactor: provenance getters now return Option<&str>
  • reduce internal code duplication

@molpopgen
refactor: provenance getters now return Option<&str>
3684efb 
BREAKING CHANGE: return value changed.
Existing code only breaks if it depended on the return
value being a String.
@molpopgen
reduce internal code duplication
f50d651
@molpopgen molpopgen merged commit 4181439 into main Nov 9, 2022
@molpopgen molpopgen deleted the provenance_copy_free_access branch November 9, 2022 04:42
molpopgen added a commit that referenced this pull request Nov 9, 2022
@molpopgen
refactor: Return &str from provenance table getters (#403)
aa94e1e 
* reduce internal code duplication

BREAKING CHANGE: return value changed.
Existing code only breaks if it depended on the return
value being a String.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@molpopgen