Allow calling heartbeat from eachMessage handler
#1255
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
julienvincent
commented
Dec 17, 2021
Comment on lines
+886
to
+887
| export type EachBatchHandler = (payload: EachBatchPayload) => Promise<void> | ||
| export type EachMessageHandler = (payload: EachMessagePayload) => Promise<void> |
Contributor
Author
There was a problem hiding this comment.
I've explicitly exported these two types to allow using them in utils and libraries (another small pain-point of mine :)
Collaborator
|
Could you please write a test that makes use of this? It's pretty simple, but it's more to prevent regression. It would also be good if you could update the docs with the new property. |
Contributor
Author
|
Will do. Also need to get the existing tests to pass |
julienvincent
force-pushed
the
feature/each-message-heartbeat
branch
from
7b7344b to
ed77244
Compare
Contributor
Author
|
@Nevon That should do it. Let me know if anything else is required |
Nevon
approved these changes
Dec 27, 2021
This was referenced Sep 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a small improvement for a pain-point I have had for a while where I have often had to 'eject' out to an
eachBatchhandler just to gain access to the heartbeat function.Sometimes consumers have to do a lot of work for individual messages in a topic and in these scenarios it makes sense to have access to the heartbeat function to avoid the session timeout and keep the consumer alive.