Skip to content

Disable link functionality on disabled btn-link #25645

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
XhmikosR merged 2 commits into from
Mar 12, 2018
Merged

Disable link functionality on disabled btn-link #25645

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f7a0989
Disable link functionality on disabled btn-link
peteretelej Feb 16, 2018
354df13
Merge branch 'v4-dev' into fix/btn-link
XhmikosR Mar 12, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
Disable link functionality on disabled btn-link 
Future-proof disabling of clicks on disabled btn-link. Fixes #25639
ensuring consistency between btn-link <button>s and <a>s when disabled.
  • Loading branch information
@peteretelej
peteretelej committed Feb 16, 2018
commit f7a09893ee503ca02801d1197b4dd2687476be27
1 change: 1 addition & 0 deletions scss/_buttons.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -100,6 +100,7 @@ fieldset:disabled a.btn {
&:disabled,
&.disabled {
color: $btn-link-disabled-color;
pointer-events: none;
}

// No need for an active state here
Expand Down