Skip to content

Variable transition durations #25662

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Johann-S merged 5 commits into from
Mar 13, 2018
Merged

Variable transition durations #25662

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
b06f41c
Variable transition durations
MartijnCuppens Feb 19, 2018
81bd16c
Merge branch 'v4-dev' into variable-transition-durations
MartijnCuppens Mar 13, 2018
be57118
More explicit detection of ms unit
MartijnCuppens Mar 13, 2018
5c0b61f
Merge branch 'v4-dev' into variable-transition-durations
XhmikosR Mar 13, 2018
ee6a836
Remove unneeded check for ms, jQuery takes care of this
MartijnCuppens Mar 13, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
More explicit detection of ms unit 
See #25662 (comment)
  • Loading branch information
@MartijnCuppens
MartijnCuppens committed Mar 13, 2018
commit be5711822e7b9b555fd34d68ac14cc808fff97c4
2 changes: 1 addition & 1 deletion js/src/util.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -118,7 +118,7 @@ const Util = (($) => {
transitionDuration = transitionDuration.split(',')[0]

// Multiply by 1000 if transition-duration is defined in seconds
return transitionDuration.indexOf('ms') > -1
return transitionDuration.indexOf('ms') !== -1
? parseFloat(transitionDuration)
: parseFloat(transitionDuration) * MILLISECONDS_MULTIPLIER
},
Expand Down