Skip to content

Fix order of Save/Close buttons in modal code example #25855

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
patrickhlauke merged 2 commits into from
Mar 15, 2018
Merged

Fix order of Save/Close buttons in modal code example #25855

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a537b21
#25853 minor typo fix
Bennet11 Mar 15, 2018
aed39c6
requested changes: highlighted html fixed
Bennet11 Mar 15, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
requested changes: highlighted html fixed
  • Loading branch information
@Bennet11
Bennet11 committed Mar 15, 2018
commit aed39c6b842a13c40f1d78f139ca531899936c0d
4 changes: 2 additions & 2 deletions docs/4.0/components/modal.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,8 +45,8 @@ Below is a _static_ modal example (meaning its `position` and `display` have bee
<p>Modal body text goes here.</p>
</div>
<div class="modal-footer">
<button type="button" class="btn btn-primary">Save changes</button>
<button type="button" class="btn btn-secondary" data-dismiss="modal">Close</button>
Copy link
Copy Markdown
Member

@patrickhlauke patrickhlauke Mar 15, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

leave the order here as it is originally, but change the order in the {% highlight html %} that comes immediately after instead. the live example is right/consistent with the rest of the page, it's the visible highlighted html code that's wrong

Copy link
Copy Markdown
Contributor Author

@Bennet11 Bennet11 Mar 15, 2018 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the input and clarification! I'll try to do it now.

Copy link
Copy Markdown
Contributor Author

@Bennet11 Bennet11 Mar 15, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The test seems to be failing though.

<button type="button" class="btn btn-primary">Save changes</button>
</div>
</div>
</div>
Expand All @@ -67,8 +67,8 @@ Below is a _static_ modal example (meaning its `position` and `display` have bee
<p>Modal body text goes here.</p>
</div>
<div class="modal-footer">
<button type="button" class="btn btn-primary">Save changes</button>
<button type="button" class="btn btn-secondary" data-dismiss="modal">Close</button>
<button type="button" class="btn btn-primary">Save changes</button>
</div>
</div>
</div>
Expand Down