improve coverage for our Alert plugin

js/src/alert.js

@@ -58,9 +58,11 @@ const Alert = (($) => {
     // Public
 
     close(element) {
-      element = element || this._element
+      let rootElement = this._element
+      if (element) {
+        rootElement = this._getRootElement(element)
+      }
 
-      const rootElement = this._getRootElement(element)
       const customEvent = this._triggerCloseEvent(rootElement)
 
       if (customEvent.isDefaultPrevented()) {

js/tests/unit/.eslintrc.json

@@ -7,6 +7,7 @@
   "globals": {
     "sinon": false,
     "Util": false,
+    "Alert": false,
     "Button": false
   },
   "parserOptions": {

js/tests/unit/alert.js

@@ -80,4 +80,43 @@ $(function () {
       })
       .bootstrapAlert('close')
   })
+
+  QUnit.test('close should use internal _element if no element provided', function (assert) {
+    assert.expect(1)
+
+    var done = assert.async()
+    var $el = $('<div/>')
+    var $alert = $el.bootstrapAlert()
+    var alertInstance = $alert.data('bs.alert')
+
+    $alert.one('closed.bs.alert', function () {
+      assert.ok('alert closed')
+      done()
+    })
+
+    alertInstance.close()
+  })
+
+  QUnit.test('dispose should remove data and the element', function (assert) {
+    assert.expect(2)
+
+    var $el = $('<div/>')
+    var $alert = $el.bootstrapAlert()
+
+    assert.ok(typeof $alert.data('bs.alert') !== 'undefined')
+
+    $alert.data('bs.alert').dispose()
+
+    assert.ok(typeof $alert.data('bs.button') === 'undefined')
+  })
+
+  QUnit.test('should return alert version', function (assert) {
+    assert.expect(1)
+
+    if (typeof Alert !== 'undefined') {
+      assert.ok(typeof Alert.VERSION === 'string')
+    } else {
+      assert.notOk()
+    }
+  })
 })