Skip to content

v4: Fix prevented show event disables modals with fade class from being displayed again #34087

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 25, 2021
Merged

v4: Fix prevented show event disables modals with fade class from being displayed again #34087

merged 2 commits into from
Jul 25, 2021

Conversation

alpadev
Copy link
Contributor

@alpadev alpadev commented May 22, 2021

Fixes #34055

@alpadev
fix(modal): change the order we return from show() method
fa6c6bc 
In case of a modal with fading enabled, a prevented show event can cause show to not showing the modal anymore.

See #34055
@alpadev alpadev requested a review from XhmikosR May 22, 2021 23:44
@alpadev alpadev requested a review from a team as a code owner May 22, 2021 23:44
@XhmikosR XhmikosR requested a review from GeoSot July 25, 2021 05:37
@XhmikosR XhmikosR merged commit b010a6f into v4-dev Jul 25, 2021
@XhmikosR XhmikosR deleted the alpa/fix-prevented-modal-stuck-v4 branch July 25, 2021 17:36
@renovate renovate bot mentioned this pull request May 16, 2022
Open
1 task
This was referenced May 19, 2022
Open
Open
@crespire crespire mentioned this pull request Apr 5, 2023
Merged
10 tasks
@RohitM-IN RohitM-IN mentioned this pull request May 19, 2024
Open
@humanbot humanbot mentioned this pull request May 20, 2024
Open
@saurabharch saurabharch mentioned this pull request May 20, 2024
Open
@h-gj h-gj mentioned this pull request May 21, 2024
Open
@RohitM-IN RohitM-IN mentioned this pull request May 22, 2024
Open
@jelenaCleo jelenaCleo mentioned this pull request May 22, 2024
Open
@snyk-io snyk-io bot mentioned this pull request May 23, 2024
Open
@Mhmonicox Mhmonicox mentioned this pull request May 24, 2024
Open
@RohitM-IN RohitM-IN mentioned this pull request May 24, 2024
Open
@jelenaCleo jelenaCleo mentioned this pull request May 24, 2024
Open
@ryanwittmers ryanwittmers mentioned this pull request May 24, 2024
Open
@jelenaCleo jelenaCleo mentioned this pull request May 25, 2024
Open
@RohitM-IN RohitM-IN mentioned this pull request May 25, 2024
Open
@angelika-draczynska angelika-draczynska mentioned this pull request May 26, 2024
Open
@ezelf86 ezelf86 mentioned this pull request May 26, 2024
Open
@RohitM-IN RohitM-IN mentioned this pull request May 27, 2024
Open
@RohitM-IN RohitM-IN mentioned this pull request Sep 21, 2024
Open
@ryanwittmers ryanwittmers mentioned this pull request Sep 21, 2024
Open
@tiff-es tiff-es mentioned this pull request Sep 22, 2024
Open
@blakegreendev blakegreendev mentioned this pull request Sep 22, 2024
Open
@dingo4dev dingo4dev mentioned this pull request Sep 22, 2024
Closed
This was referenced Sep 22, 2024
Open
Open
Open
Open
Open
Open
Open
@RohitM-IN RohitM-IN mentioned this pull request Sep 29, 2024
Open
@imsureshbala imsureshbala mentioned this pull request Sep 29, 2024
Open
This was referenced Sep 30, 2024
Open
Open
Open
Open
This was referenced Oct 4, 2024
Open
Open
@RohitM-IN RohitM-IN mentioned this pull request Oct 4, 2024
Open
@saadi1995 saadi1995 mentioned this pull request Oct 5, 2024
Open
@RohitM-IN RohitM-IN mentioned this pull request Oct 5, 2024
Open
@RohitM-IN RohitM-IN mentioned this pull request Oct 30, 2024
Open
@snyk-kevin snyk-kevin mentioned this pull request Nov 3, 2024
Open
@leopard1982 leopard1982 mentioned this pull request Nov 3, 2024
Open
@RohitM-IN RohitM-IN mentioned this pull request Nov 6, 2024
Open
This was referenced Aug 19, 2025
Closed
Closed
@dependabot dependabot bot mentioned this pull request Aug 26, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GeoSot GeoSot GeoSot approved these changes

@XhmikosR XhmikosR Awaiting requested review from XhmikosR

Assignees
No one assigned
Labels
js v4
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@alpadev @GeoSot @XhmikosR