Skip to content
This repository was archived by the owner on May 30, 2022. It is now read-only.

Sets custom user agent with Authy gem #110

Merged
philnash merged 3 commits into from
Jan 31, 2019
Merged

Sets custom user agent with Authy gem #110

philnash merged 3 commits into from
Jan 31, 2019

Conversation

@philnash
Copy link
Contributor

@philnash philnash commented Jan 25, 2019

This will set the user agent to something like:

DeviseAuthy/1.10.0 - AuthyRuby/2.7.5 (x86_64-darwin18, Ruby 2.6.0)

This allows us to still check all requests that include AuthyRuby as the user agent, but also drill down to DeviseAuthy specifically too.

Will this work for you @robinske?

@philnash philnash requested a review from robinske January 25, 2019 05:30
@philnash philnash requested review from suarezjulian and removed request for robinske January 31, 2019 14:09
suarezjulian
suarezjulian approved these changes Jan 31, 2019
View reviewed changes
Copy link

@suarezjulian suarezjulian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this should work Thanks!

@philnash philnash merged commit ec7b99f into twilio:master Jan 31, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@suarezjulian suarezjulian suarezjulian approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@philnash @suarezjulian