[SPARK-24373][SQL] Add AnalysisBarrier to RelationalGroupedDataset's … #31
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…and KeyValueGroupedDataset's child When we create a `RelationalGroupedDataset` or a `KeyValueGroupedDataset` we set its child to the `logicalPlan` of the `DataFrame` we need to aggregate. Since the `logicalPlan` is already analyzed, we should not analyze it again. But this happens when the new plan of the aggregate is analyzed. The current behavior in most of the cases is likely to produce no harm, but in other cases re-analyzing an analyzed plan can change it, since the analysis is not idempotent. This can cause issues like the one described in the JIRA (missing to find a cached plan). The PR adds an `AnalysisBarrier` to the `logicalPlan` which is used as child of `RelationalGroupedDataset` or a `KeyValueGroupedDataset`. added UT Author: Marco Gaido <[email protected]> Closes apache#21432 from mgaido91/SPARK-24373. (cherry picked from commit de01a8d)
Member
|
@curtishoward is this just a cherry-pick? If so, we don't need to review this. |
Collaborator
Author
|
Hi @icexelloss - OK, I'll close these two PRs then, and discuss with Wenbo before pushing my changes. Thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…and KeyValueGroupedDataset's child
When we create a
RelationalGroupedDatasetor aKeyValueGroupedDatasetwe set its child to thelogicalPlanof theDataFramewe need to aggregate. Since thelogicalPlanis already analyzed, we should not analyze it again. But this happens when the new plan of the aggregate is analyzed.The current behavior in most of the cases is likely to produce no harm, but in other cases re-analyzing an analyzed plan can change it, since the analysis is not idempotent. This can cause issues like the one described in the JIRA (missing to find a cached plan).
The PR adds an
AnalysisBarrierto thelogicalPlanwhich is used as child ofRelationalGroupedDatasetor aKeyValueGroupedDataset.added UT
Author: Marco Gaido [email protected]
Closes apache#21432 from mgaido91/SPARK-24373.
(cherry picked from commit de01a8d)
What changes were proposed in this pull request?
(Please fill in changes proposed in this fix)
How was this patch tested?
(Please explain how this patch was tested. E.g. unit tests, integration tests, manual tests)
(If this patch involves UI changes, please attach a screenshot; otherwise, remove this)